ci(sandbox): publish @bunny.net/sandbox in release workflow#112
Conversation
|
@codex review |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07c28f31cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Publish @bunny.net/sandbox | ||
| run: | | ||
| cd packages/sandbox | ||
| npm publish --access public |
There was a problem hiding this comment.
Rewrite workspace dependencies before publishing sandbox
Publishing from packages/sandbox as-is produces a tarball whose package.json still contains "@bunny.net/openapi-client": "workspace:*". I confirmed this with npm pack and then installing the tarball in an empty project, which fails with EUNSUPPORTEDPROTOCOL Unsupported URL Type "workspace:"; npm consumers of the newly published SDK cannot install it until the internal dependency is converted to a registry version (or the package is built/packed via a step that rewrites workspace dependencies).
Useful? React with 👍 / 👎.
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@bunny.net/sandbox": major | |||
07c28f3 to
737efac
Compare
737efac to
8d25637
Compare
No description provided.