chore(sandbox): publish @bunny.net/sandbox to npm#109
Conversation
|
@codex review |
🦋 Changeset detectedLatest commit: 5c07f9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@bunny.net/sandbox": patch | |||
There was a problem hiding this comment.
TypeScript-source exports will fail for Node.js consumers
packages/sandbox/package.json exports ./src/index.ts directly (no build script, no dist/), unlike the already-published sibling @bunny.net/openapi-client which compiles to dist/index.js before publishing. Any Node.js consumer who runs npm install @bunny.net/sandbox will get an unresolvable TypeScript entry point. The README.md only shows bun add, so Bun-only seems intentional — but without an engines field (e.g. "engines": { "bun": ">=1.0.0" }) in package.json, npm gives no signal that Node.js is unsupported and the package will silently fail for non-Bun environments.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a6f526cc3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "@bunny.net/sandbox": minor | ||
| --- | ||
|
|
||
| Publish @bunny.net/sandbox to npm |
There was a problem hiding this comment.
Add sandbox publishing to the release workflow
When this changeset is versioned and merged, the current release workflow still will not publish @bunny.net/sandbox: I checked .github/workflows/release.yml, and the version job only exposes outputs for cli/database-shell/openapi-client/scriptable-dns-types, with publish jobs only for those packages. Since there is no sandbox version check or publish job, this change will bump the package but leave it unpublished on npm, so the stated release action never happens.
Useful? React with 👍 / 👎.
|
@amir-at-bunny let's add the |
No description provided.