Skip to content

windows: Clip rounded retained layers#6

Merged
BumpyClock merged 1 commit into
mainfrom
fix/windows-rounded-retained-layer-mask
Jul 15, 2026
Merged

windows: Clip rounded retained layers#6
BumpyClock merged 1 commit into
mainfrom
fix/windows-rounded-retained-layer-mask

Conversation

@BumpyClock

Copy link
Copy Markdown
Owner

Summary

  • apply rounded retained-layer masks to the untransformed DirectComposition root visual
  • keep compositor-driven child transforms and opacity inside the fixed destination-space clip
  • clear the clip when returning to direct swap-chain presentation
  • cover rectangular and asymmetric rounded mask conversion

Why

The rounded content-mask change added shader coverage for Windows primitives, but the DirectComposition retained-layer fast path bypassed the final rounded mask. A full-viewport retained layer could therefore move cached pixels into rounded-corner regions during compositor-only transforms.

Verification

  • cargo check -p gpui
  • cargo check -p gpui_windows
  • cargo fmt --all --check
  • git diff --check
  • local CodeRabbit review: 0 findings
  • independent Codex review: no blockers

The local x86_64-pc-windows-msvc cross-check reached dependency compilation but was blocked by the macOS host lacking lib.exe; Windows CI provides native validation.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 25 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f117e07b-0e66-431a-8cf3-c3b631e40651

📥 Commits

Reviewing files that changed from the base of the PR and between 692d54d and 9f1fee1.

📒 Files selected for processing (2)
  • crates/gpui_windows/src/directx_renderer.rs
  • crates/gpui_windows/src/retained_compositor.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/windows-rounded-retained-layer-mask

Comment @coderabbitai help to get the list of available commands.

@BumpyClock
BumpyClock merged commit 4332ea7 into main Jul 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant