Skip to content

fix: address floating sidebar review feedback#6

Merged
BumpyClock merged 1 commit into
mainfrom
fix/sidebar-elevation-noise-tiles
Jul 15, 2026
Merged

fix: address floating sidebar review feedback#6
BumpyClock merged 1 commit into
mainfrom
fix/sidebar-elevation-noise-tiles

Conversation

@BumpyClock

Copy link
Copy Markdown
Owner

Closes #5

Description

  • preserve SurfacePreset::panel() theme elevation for SidebarShell and FloatingSidebar unless callers explicitly set .elevation(...)
  • clamp scale-aware noise tiles to a minimum logical size of 1px so extreme scale factors cannot produce zero-sized tiles
  • cover theme-default, explicit elevation, and extreme-scale behavior; update Floating Sidebar docs

Screenshot

Not applicable. This follow-up restores theme-default selection and hardens internal noise layout calculations without changing component structure.

How to Test

cargo fmt --all --check
cargo check -p gpui-component -p gpui-component-story -p gpui-wry
cargo test -p gpui-component --lib
cargo clippy -p gpui-component -- --deny warnings
git diff --check

Local review:

  • independent read-only reviewer: no blockers
  • local CodeRabbit review against origin/main: implementation findings addressed; remaining suggestion requested redundant render-plumbing coverage already exercised at the SidebarShell::surface_preset() rendering boundary

Checklist

  • I have read the CONTRIBUTING document and followed the guidelines.
  • Reviewed the changes in this PR and confirmed AI generated code is accurate.
  • Passed cargo run for story tests related to the changes. Focused checks and all 180 library tests passed; GUI recapture was not required for this logic follow-up.
  • Tested macOS, Windows and Linux platforms performance. Not platform-specific; GitHub CI provides platform validation.

AI Assistance

Implementation and review were AI-assisted with Claude Code. The diff was independently reviewed by a read-only reviewer and CodeRabbit before submission.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 13 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 39a892e5-e20c-472e-8702-a7609116d965

📥 Commits

Reviewing files that changed from the base of the PR and between 01847f3 and af64972.

📒 Files selected for processing (4)
  • crates/ui/src/floating_sidebar/mod.rs
  • crates/ui/src/sidebar_shell/mod.rs
  • crates/ui/src/surface/mod.rs
  • docs/docs/components/sidebar.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sidebar-elevation-noise-tiles

Comment @coderabbitai help to get the list of available commands.

@BumpyClock
BumpyClock merged commit 95e4b03 into main Jul 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant