Connect Add Column to Sources - #2662
Draft
3mdistal wants to merge 5 commits into
Draft
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
Visual recap — skippedThe visual recap job did not run for this pull request. This is informational only and does not block the PR. Recap skipped for |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Content databases can already connect Builder, Notion, local tables, and local-folder Sources, but that capability is hidden in database settings. Someone adding a column has no obvious route to discover source-backed fields, so the existing Source model feels like separate database machinery instead of a natural way to add data.
Approach
Add one small handoff from the existing Add column menu into the existing Sources UI. A successful connection returns to the database with Add column open and the newly available fields grouped under
From [source]. Closing Sources is a true cancel: it returns to the database without reopening Add column or mutating a connection.This PR deliberately does not add source suggestions, relationship matching, formula UI, or a separate “add property from this source” workflow. The existing Sources UI remains responsible for choosing and connecting a source.
What changed
Connect a sourceentry to Add column, including localized search matching.From [source]fields.Safety and operations
Verification
Exact repaired head:
0c30726392256c8c7711dc367fbe439cb0dd92c5, refreshed onto currentmainat86ea1866721a64527b412cd43ad32428e490f4a9.local_refinementdeclaration and no deterministic findings.git diff --checkpassed.From QA Books 2662grouping with federated fields. No console or page errors were observed in the successful run.Fast tests lane-2and its aggregate. The lane failed identically on its one bounded rerun becausepackages/docs/server/plugins/agent-chat.spec.tscould not import the generatedpackages/docs/.generated/actions-registry.js; the other 161 tests in that package run passed. This PR changes no Docs or CI-generation files, so that unrelated base/workflow defect is intentionally not folded into this stack base.Review focus
From [source]grouping understandable without changing source-field identity or write ownership?Prospective stack order
This draft is the intended base of a future dependency stack, but this PR does not create or authorize any child branch or PR:
Product roadmap impact