feat(components): check the ingress class the chart requests on OpenShift (budctl 0.3.2) - #3
Merged
Merged
Conversation
…hift components.ingress on OpenShift verified the Ingress Operator and the default IngressController, and never looked at the class the chart's Ingresses name. The Bud charts default to ingress.className: traefik and ingress.isTraefik: true, so an OpenShift install without the overrides passed this check while the router turned none of its Ingresses into Routes and the sync failed on Traefik objects. - On OpenShift, compare the rendered Ingresses' class with the cluster's IngressClasses: a missing class blocks, a class served by a controller other than the router (openshift.io/ingress-to-route) is a risk, and openshift-default passes and says so. - On any cluster, block when the render contains Traefik objects (Middleware) and the cluster serves no Traefik API: the sync stops at the first one with "no matches for kind". The same failure hits an ingress-nginx cluster. - Without a render, the pass names the values to set on OpenShift; when values were given but the chart did not render, it says that instead. - components.ingress depends on config, so `--only components` still renders. - Remedies name the charts' real key, ingress.className, not global.ingress.className; the stale "OpenShift has no IngressClass" comment is corrected. Verified against a single-node OpenShift 4.22 cluster with the published bud 1.2.8 chart: infra's values.openshift.yaml passes, the chart defaults block on three Traefik Middlewares, and className traefik blocks on the missing class. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dittops
force-pushed
the
claude/openshift-ingress-class
branch
from
September 15, 2026 06:46
3c5fa9f to
0a5e9da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On OpenShift,
components.ingresschecked the Ingress Operator and the default IngressController, but never the class the chart's Ingresses name. The Bud charts default toingress.className: traefikandingress.isTraefik: true. An OpenShift install missing the overrides therefore passed this check, while the router turned none of its Ingresses into Routes and the sync failed on TraefikMiddlewareobjects.Changes
openshift.io/ingress-to-route) → RISK.openshift-default→ PASS, and says so.components.ingressdepends onconfig, so--only componentsstill renders.ingress.className(notglobal.ingress.className), and the stale "OpenShift has no IngressClass" comment is corrected.budctl 0.3.2commit (installer pin).Verification
7 new tests (5 fail on the pre-change code); full suite passes. Against a single-node OpenShift 4.22 cluster with the published
bud 1.2.8chart:ingress.className: openshift-default/ingress.isTraefik: falsevalues.openshift.yamlopenshift-default, served by the routerclassName: traefik,isTraefik: falsetraefikdoes not exist (the dry run does not catch this one)🤖 Generated with Claude Code