New EEex Feature: Tweak EEex_GetUserDataAuxiliary()#128
Open
4Luke4 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a significant refactor and extension of the user data auxiliary (UDAux) marshalling system, as well as new infrastructure for handling persistent auxiliary data for game objects.
Key changes are grouped below:
UDAux Marshalling System Refactor and Extension
EEex_Marshal_Private_*). This simplifies the code and centralizes marshalling logic.Persistent Auxiliary Data Support
EEex_UserDataAuxiliaryPersistentand extendedEEex_GetUserDataAuxiliaryto support marking auxiliary data as persistent, allowing certain user data to survive across game sessions. In particular:CGameContainer,CItem(container-owned)CGameEffect,CItem(sprite-owned)CStore,CStoreFileItemRequires: Bubb13/InfinityLoader#9.
Notes
@Bubb13
As far as
CGameEffectuserdata are concerned, this solution does not work for Local variables stored as attached effects onCREfiles, i.e.op187effects (the same most likely holds for265/309). However, that's probably intended since those are kinda special...