Skip to content

[BI-3004] Fix logging messages referencing exrefs for ous #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jloux-brapi wants to merge 1 commit into
base: feature/BI-2916
Choose a base branch
from
Open

[BI-3004] Fix logging messages referencing exrefs for ous #538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/breedinginsight/brapi/v2/BrAPIObservationUnitController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ public HttpResponse<BrAPIObservationUnitListResponse> observationunitsGet(@PathV
@Get("/observationunits/{observationUnitDbId}")
@ProgramSecured(roleGroups = {ProgramSecuredRoleGroup.PROGRAM_SCOPED_ROLES})
public HttpResponse<BrAPIObservationUnitSingleResponse> observationunitsObservationUnitDbIdGet(@PathVariable("programId") UUID programId, @PathVariable("observationUnitDbId") String observationUnitDbId) {
log.debug("observationunitsObservationUnitDbIdGet: fetching ou by externalReferenceId: " + observationUnitDbId);
log.debug("observationunitsObservationUnitDbIdGet: fetching ou by dbId: " + observationUnitDbId);
Optional<Program> program = programService.getById(programId);
if(program.isEmpty()) {
log.warn("Program id: " + programId + " not found");
Expand All @@ -158,7 +158,7 @@ public HttpResponse<BrAPIObservationUnitSingleResponse> observationunitsObservat
try {
List<BrAPIObservationUnit> ous = observationUnitDAO.getObservationUnitsById(List.of(observationUnitDbId), program.get());
if(ous.size() != 1) {
log.warn("did not find a single ou with externalReferenceId: " + observationUnitDbId);
log.warn("did not find a single ou with dbId: " + observationUnitDbId);
return HttpResponse.notFound();
}
setDbIds(ous.get(0));
Expand Down
Loading