Conversation
First-round edits to README, prior to attempting installation
…r for larger birefnet weights
Initial README edits, edited to resolve conflicts with dev branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General first-pass edits across the README
Existing logic for LFS file install was to exclude the large BiRefNet weights in the
.lfsconfigand override that exclusion withgit lfs pull --include [weights.pth]when the user requests it.I could not get that override to work correctly, either on my Macbook or on an Ubuntu docker image. The man pages for
git lfssuggest that it should work, not sure what the problem is.Instead, I flipped the logic around in
weights.pyand in the.lfsconfig. Instead of the lfsconfig excluding the file and the commands including it, the two relevant lines in the lfsconfig are commented out and the weights fetching tools will always rungit lfs pull --exclude [weights.pth]by default, unless the user specifies that they want to retrieve the BiRefNet weights