feat: stacked mobile command menus and language-thread local-dev - #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
menu_locale.rs(hub!help, transcription,!translation, privacy TEE cmds, unavailable) so each command sits on its own line with a short indented description — long!cmd — descone-liners wrap badly on mobile Signal. Compound the layout intodocs/solutions/signal-mobile-menus.md; module docs link to it. EN/ES stay structural twins; prose/status blocks stay paragraphs.create_group/ invite (!translate-me-on); English target skips NEAR; failure falls back to English. Shorter main-group join confirmation ({lang} joined {name} thread).Detector::with_allowlist) so short English (and other pair langs) are not mislabeled open-vocab (e.g. Norwegian); lower confidence bar inside the active pair.docker/Dockerfile.proxyfor the current Cargo workspace (stubs forsignal-bot/signal-bot-core/signal-bot-transcription; drop retired crates) plus Cargo registry retries / sparse index / longer HTTP timeout.docs/local-dev/for dual-stack bring-up, Signal captcha registration, verify SMS/voice, and log monitoring; link from root README.Context
Long one-liner command menus break mid-phrase on mobile Signal (seen on
!translation). Same pattern lived on hub help, transcription help, and privacy TEE lists — fix once and compound the standard.Also unblocks local Docker bring-up (proxy image + captcha/registration guide) while we work toward a clean Phala CVM deploy, and improves Language Thread create/join UX plus short-message language detection for in-chat translate-all.
Test plan
Mobile menus
cargo test -p signal-bot --lib commands::menu_localecargo test -p signal-bot --lib commands::help commands::privacy!help,!translation,!privacy(stacked cmds; no mid-phrase wrap on primary commands)Language Threads / detection
!translate-me-on escreates a sidecar whose name and welcome are Spanish (or English fallback if NEAR fails)add_members) still works without re-creating the groupes/enauto-translate group routes correctly (not stuck as Norwegian / wrong side of the pair)Docker / local-dev
docker build -f docker/Dockerfile.proxy .succeedsdocs/local-dev/README.mdcaptcha → register → verify for one stack