fix(scheduling): private reminders must not leak into a channel - #97
Open
BreadrichEngels wants to merge 1 commit into
Open
fix(scheduling): private reminders must not leak into a channel#97BreadrichEngels wants to merge 1 commit into
BreadrichEngels wants to merge 1 commit into
Conversation
A scheduled task's final reply is delivered to the task's bound chat (channel/thread). So even when the task correctly DMs the requester, its "done" narration leaks to a channel — a personal reminder ended up visible to another user. Add a rule: private/DM-only tasks must deliver ONLY via dm_user to the requester(s) and wrap their entire response in <internal> tags so nothing is posted to any channel.
RonTuretzky
force-pushed
the
fix/private-reminder-no-channel-leak
branch
from
July 31, 2026 20:21
7e4bf98 to
7ab17c3
Compare
RonTuretzky
pushed a commit
that referenced
this pull request
Jul 31, 2026
…king into channels (#46) Reminders/private scheduled tasks were leaking their result narration (e.g. "DM sent to X ✅") into the bound chat/thread, where non-requesters could see it. The live-message path was fixed in #46 via replyToMessageId anchoring, but the scheduled-task path was never covered, and #97's 'wrap narration in <internal>' is a prompt-level rule the agent can forget. Add a structural per-task 'delivery' mode: - 'channel' (default): result posts to chat_jid, unchanged behavior - 'silent': orchestrator never posts the result to a channel; the real output goes out via dm_user during the run Enforced in the scheduler (shouldNarrateToChannel), not by the agent. DB column is NOT NULL DEFAULT 'channel' (additive migration), so every existing task keeps current behavior — zero regression. - types: ScheduledTask.delivery? - db: column + additive migration + createTask insert - ipc: schedule_task parses/persists delivery - container tool: schedule_task gains delivery param + guidance - skill: scheduling-rules documents silent for private reminders - tests: db round-trip/default + shouldNarrateToChannel predicate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
A user (bagelface) asked for a private "remind me in 8 hours" reminder. The reminder DM was delivered to them correctly — but the scheduled task's final narration ("DM sent to bagelface ✅") was posted to the task's bound chat, which threaded into a channel where another user could see it. A personal reminder leaked.
Root cause
A scheduled task's final assistant reply is delivered to the chat the task is bound to (channel/thread).
dm_usercorrectly delivered the private DM, but the agent's "done" message wasn't suppressed, so it surfaced publicly. Thescheduling-rulesskill had no guidance on output scoping for private tasks.Fix
Adds a "Private Reminders Must Not Leak Into a Channel" section to
container/skills/scheduling-rules/SKILL.md. Going forward, any reminder / private / DM-only task must:dm_userto the requester(s);<internal></internal>so no narration is posted to any channel/thread;isolated; andIncludes a ready-to-use template prompt so the pattern is followed every time.
Test plan
🤖 Generated with Claude Code