Skip to content

Add Bearing Fault Detection (UORED) example akida1 - #27

Open
dmclellandbc wants to merge 15 commits into
mainfrom
add_example_uored_akida1
Open

dmclellandbc wants to merge 15 commits into
mainfrom
add_example_uored_akida1

Conversation

@dmclellandbc

Copy link
Copy Markdown
Collaborator

This PR integrates a new Akida 1 model for Bearing Fault Detection (1D time series vibration data), using the UORED-VAFCLS dataset.

Two performance metrics are presented, to highlight a systematic methodological flaw in the evaluation of models on this (and related) datasets.

Two TODOs remain beyond this PR:

  • Data file to be hosted on Brainchip server
  • Training and Benchmarking notebooks (as per example template) to be added. Committing without these in the first place in order to make the model available for internal technical evaluation.

@sbruers-brainchip sbruers-brainchip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one,
Mainly rewording of docstrings.
One question about the actual input shape worth checking: comment showed (1200, 35) but the code said (300, 140), so I assumed that was the correct one.
I feel like a lot of information is currently "hidden" in each file's docstring, so it's a bit hard to follow, but I am assuming this will be resolved by the soon to be notebooks.

Comment thread akida1/model_zoo/uored_vafcls/README.md Outdated
Comment thread akida1/model_zoo/uored_vafcls/README.md Outdated
Comment thread akida1/model_zoo/uored_vafcls/README.md
Comment thread akida1/model_zoo/uored_vafcls/README.md Outdated
Comment thread akida1/model_zoo/uored_vafcls/README.md
Comment thread akida1/model_zoo/uored_vafcls/uored_vafcls_naive_split.sh Outdated
Comment thread akida1/model_zoo/uored_vafcls/uored_vafcls_naive_split.sh Outdated
Comment thread akida1/model_zoo/uored_vafcls/uored_vafcls_train.py Outdated
Comment thread akida1/model_zoo/uored_vafcls/uored_vafcls_train.py Outdated
Comment thread akida1/model_zoo/uored_vafcls/uored_vafcls_train.sh Outdated

@sbruers-brainchip sbruers-brainchip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one,
Mainly rewording of docstrings.
One question about the actual input shape worth checking: comment showed (1200, 35) but the code said (300, 140), so I assumed that was the correct one.
I feel like a lot of information is currently "hidden" in each file's docstring, so it's a bit hard to follow, but I am assuming this will be resolved by the soon to be notebooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants