fix: respect Item Price validity dates when fetching POS prices - #341
Open
tushar-git26 wants to merge 1 commit into
Open
fix: respect Item Price validity dates when fetching POS prices#341tushar-git26 wants to merge 1 commit into
tushar-git26 wants to merge 1 commit into
Conversation
Item Price queries fetched all rows for an item/price list without filtering on valid_from/valid_upto and collapsed them into a UOM-keyed map where the last arbitrarily-ordered row wins. With multiple Item Price records for the same item, the POS could show an expired or stale price instead of the latest valid one. Add validity-date filters and order by valid_from so the newest valid price wins, matching ERPNext core get_item_price behaviour. Applies to search_by_barcode, get_item_variants, get_items (grid and template min variant price) and get_items_bulk. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item Price queries fetched all rows for an item/price list without filtering on valid_from/valid_upto and collapsed them into a UOM-keyed map where the last arbitrarily-ordered row wins. With multiple Item Price records for the same item, the POS could show an expired or stale price instead of the latest valid one.
Add validity-date filters and order by valid_from so the newest valid price wins, matching ERPNext core get_item_price behaviour. Applies to search_by_barcode, get_item_variants, get_items (grid and template min variant price) and get_items_bulk.