docs: discuss-first for always-on prose; version renumbering at merge - #25
Open
HarshRajSinghania wants to merge 2 commits into
Open
HarshRajSinghania wants to merge 2 commits into
HarshRajSinghania wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Documents two contributor rules that were not inferable from CONTRIBUTING.md, as requested in #24:
devyou branched from and do not rebase only to chase the number; the maintainer renumbersplugin.jsonand the CHANGELOG entry at merge ifdevhas moved. The same sentence is on the version checkbox in.github/pull_request_template.md.Docs-only. No plugin version bump.
Why
#24: review of the first external PR showed both gaps cost review time and are one or two sentences each.
Review notes
Diff is
CONTRIBUTING.md(Submitting changes) and.github/pull_request_template.md(version checkbox).Wording follows the issue text; existing paragraph about walks that need a tenant was left unchanged.
Plugin version bumped in
.claude-plugin/plugin.jsonwith a CHANGELOG entry (user-visible plugin change) / not needed (docs-only).Safety boundary: this PR does not touch
hooks/gs-admin-guard.mjsor ask-rules generation.Skill edits: not applicable.
No test or dev step touched real gs-admin state.
No tenant/instance/org-specific data in commit messages or this PR body.