Skip to content

D: --deep and Phase 6 boundaries (F-457), guard repeat-ask remedy (F-453), work-ordering bullet (#1) — plugin 0.41.1 - #22

Merged
BradleyDB merged 4 commits into
devfrom
round-d-prose
Sep 16, 2026
Merged

BradleyDB merged 4 commits into
devfrom
round-d-prose

Conversation

@BradleyDB

Copy link
Copy Markdown
Owner

Base branch must be dev, not main. Base is dev.

Regenerated output committed? build/build-plugin-gs-superadmin.mjs was run; nothing under data/, reference/, wiki/ or plugins/gs-superadmin/reference/ changed (prose + one hook message only).

What

Session D of the September rounds: DC-1 (bus F-457), DC-2 (F-453), DC-3 (issue #1). Plugin 0.41.1.

  • --deep <domain> states its phases (setup/SKILL.md): Phases 1–2, then straight to Phase 5 — Phases 3 and 4 never re-run and nothing re-lists. Ruled 2026-09-16 over the plan's re-list-when-stale option after measuring the selection: next --upgrade takes depth-metadata entries only, so a re-list's new pending rows would never enter the --deep queue. Before spending budget the run reads one report's lookback.<domain> and relays the list's age when older than lookbackDefault, pointing at refresh (refresh step 2 stays the one home for the window). Phase 4's heading no longer reads "runs every time".
  • Phase 6 states the maps' inputs: the five lanes are the builder's ONLY inputs — the subset it takes from doc-lib's RECORDED_LANES, pointed at, not copied — so a non-lane deep ingest leaves the four maps byte-identical; deps-report is named as where that ingest pays off.
  • The guard's repeat-offense ask names the remedy (hooks/gs-admin-guard.mjs): the escalated ask on a shell-variable subcommand carries the same "spelled literally — variables belong in flag values and paths" remedy the deny already carried. test/guard-fixtures.mjs pins it on the repeat path.
  • AGENTS.md § Review-gate rules gains "Work order is not severity order" (marked not mechanically checkable). The same rule lands in the /dev-loop skill's builder lane by its own PR, BradleyDB/gs-admin-superfriends#8 — the personal skill is a symlink into that checkout.

Bus: F-457 and F-453 FIXED with Fix / Judge lines; the D-V walk (one setup --deep run to its first batch + the repeat ask read by the operator) is banked in dev/VALIDATION.md.

Closes #1

Why

F-457: four live --deep runs each improvised the same skip of a documented "runs every time", and several login cycles went to deep-ingesting a non-lane domain to improve maps that came back byte-identical — two expensive operations documented by what they do, never by what they do not. F-453 (polish, carried since Session A): the rung-1 site present at the moment of composition blocked correctly and did not say how to not need the prompt. #1: the ordering rule learned at 0.30.0 was lost with the private bus.

Review notes

Start with the Phase 5 --deep paragraph (the canon; the flag doc and Phase 4 heading are paraphrase + pointer), then the Phase 6 lane paragraph, then the varAskPart string. Mutation proof: guard-fixtures over the stashed pre-fix hook reds exactly the new check; the F-363 bound arm measures 1967 of 4096 bytes. Locally green: check-doc-drift, check-stale-facts, check-imports, check-instance-data, test-check-doc-drift, guard-fixtures, guard-oracle, claude plugin validate, plugin bundle rebuild (no diff), sweep-fence-grammar (survivor comparison EXACT). Review round (/code-review low): 1 finding (the null-days substitution rule produced an ungrammatical relay line), fixed.

  • Plugin version bumped in .claude-plugin/plugin.json with a CHANGELOG entry (0.41.1 — the ask text ships).
  • Safety boundary: this PR touches hooks/gs-admin-guard.mjs — one message string only; no ask became a deny or disappeared (the deny text is unchanged, the ask gains a sentence); test/guard-fixtures.mjs extended and mutation-proved.
  • Skill edits: cross-document consistency checked (the flag doc, Phase 4 heading and Phase 5 canon agree; the operating model and cheatsheet carry no --deep phase claim) — the setup walk is the tester round's. Session / verdict: D-V, per dev/VALIDATION.md § F-457 / F-453.
  • No test or dev step touched real gs-admin state.
  • No tenant/instance/org-specific data in commit messages or this PR body.

…eat ask names the remedy (F-453), AGENTS.md work-ordering bullet (#1); plugin 0.41.1

setup/SKILL.md: --deep runs Phases 1-2 then goes straight to Phase 5 — Phases 3-4
never re-run, nothing re-lists (next --upgrade selects metadata stubs only, so a
re-list would not feed the queue); before spending budget the run reads one report's
lookback.<domain> and relays the list's age when older than lookbackDefault, pointing
at refresh. Phase 4's heading no longer reads "runs every time". Phase 6 states the
five lanes are the builder's ONLY inputs (the subset of doc-lib's RECORDED_LANES) and
names deps-report as where a non-lane deep ingest pays off.

gs-admin-guard.mjs: the repeat-offense ask on a shell-variable subcommand carries the
same literal-spelling remedy the deny names; guard-fixtures pins it on the repeat path
(red over the pre-fix hook; F-363 bound arm 1967 of 4096 bytes).

AGENTS.md § Review-gate rules: "Work order is not severity order" — a fix that removes
an unreliable manual step is worked before the next hand-run of that step and before
any tester handoff; not mechanically checkable, stated in the handoff note.

Bus: F-457 and F-453 FIXED (Fix / Judge lines). VALIDATION: the D-V walk banked.
Plan: As-shipped (D) notes for DC-1..DC-3 and the ledger line.
BradleyDB added a commit that referenced this pull request Sep 16, 2026
…, F-453 FIXED on the branch @ hb-20260916-01 [skip ci]
BradleyDB added a commit that referenced this pull request Sep 16, 2026
BradleyDB added a commit that referenced this pull request Sep 16, 2026
… hb-20260916-01 on round-d-prose [skip ci]
BradleyDB added a commit that referenced this pull request Sep 16, 2026
…6-01, VALIDATION cleared, CI green on the verdict tip, unmerged [skip ci]
…r by domain type (D-V side observation; doc-only)
@BradleyDB
BradleyDB merged commit cec8fb8 into dev Sep 16, 2026
5 checks passed
@BradleyDB
BradleyDB deleted the round-d-prose branch September 16, 2026 15:38
BradleyDB added a commit that referenced this pull request Sep 16, 2026
…merge dispatches quoted green [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant