chore: refresh size-gate baselines#4119
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughUpdated size-gate ceilings and refreshed recorded artifact size metadata for ChangesSize-gate baseline refresh
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@baml_language/.cargo/size-gate.toml`:
- Line 50: Update or remove the explanatory baseline comments near
max_file_bytes and the corresponding entries around lines 61–67 so they match
the current recorded measurements, including Linux’s 25,560,272-byte baseline.
Leave the configured ceilings unchanged.
- Around line 49-52: Remove the duplicate TOML table declarations in the
size-gate configuration, including the repeated artifacts.baml-cli platform
headers around the affected entries. Keep one header per platform and preserve
each platform’s existing max_file_bytes ceiling so the configuration parses
successfully.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: c3f30fe1-e848-47f2-ac59-b747b42d4e6a
📒 Files selected for processing (5)
baml_language/.cargo/size-gate.tomlbaml_language/.ci/size-gate/aarch64-apple-darwin.tomlbaml_language/.ci/size-gate/wasm32-unknown-unknown.tomlbaml_language/.ci/size-gate/x86_64-pc-windows-msvc.tomlbaml_language/.ci/size-gate/x86_64-unknown-linux-gnu.toml
| [artifacts.baml-cli.platform.x86_64-unknown-linux-gnu] | ||
| max_file_bytes = 26_043_822 | ||
| max_file_bytes = 26_327_081 | ||
| # Windows x86_64: baseline 21.08 MB file (21_075_968), ceiling = baseline x1.03. | ||
| [artifacts.baml-cli.platform.x86_64-pc-windows-msvc] |
There was a problem hiding this comment.
🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win
Remove the duplicate TOML table headers.
The repeated table declarations at Lines 49, 52, 55, 60, 63, and 66 make this configuration invalid for TOML parsers, preventing the size-gate tool from loading the ceilings.
Proposed fix
[artifacts.baml-cli.platform.x86_64-unknown-linux-gnu]
-[artifacts.baml-cli.platform.x86_64-unknown-linux-gnu]
[artifacts.baml-cli.platform.x86_64-pc-windows-msvc]
-[artifacts.baml-cli.platform.x86_64-pc-windows-msvc]
[artifacts.packed-program]
-[artifacts.packed-program]
[artifacts.packed-program.platform.aarch64-apple-darwin]
-[artifacts.packed-program.platform.aarch64-apple-darwin]
[artifacts.packed-program.platform.x86_64-unknown-linux-gnu]
-[artifacts.packed-program.platform.x86_64-unknown-linux-gnu]
[artifacts.packed-program.platform.x86_64-pc-windows-msvc]
-[artifacts.packed-program.platform.x86_64-pc-windows-msvc]Also applies to: 55-67
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@baml_language/.cargo/size-gate.toml` around lines 49 - 52, Remove the
duplicate TOML table declarations in the size-gate configuration, including the
repeated artifacts.baml-cli platform headers around the affected entries. Keep
one header per platform and preserve each platform’s existing max_file_bytes
ceiling so the configuration parses successfully.
| # Linux x86_64: baseline 25.27 MB file (25_272_400), ceiling = baseline x1.03. | ||
| [artifacts.baml-cli.platform.x86_64-unknown-linux-gnu] | ||
| max_file_bytes = 26_043_822 | ||
| max_file_bytes = 26_327_081 |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Synchronize the explanatory baseline comments.
The ceilings now correspond to newer measurements, but nearby comments still cite old values—for example, Linux 25,272,400 versus the recorded 25,560,272 bytes. Update or remove these comments to avoid misleading future refreshes.
Also applies to: 61-67
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@baml_language/.cargo/size-gate.toml` at line 50, Update or remove the
explanatory baseline comments near max_file_bytes and the corresponding entries
around lines 61–67 so they match the current recorded measurements, including
Linux’s 25,560,272-byte baseline. Leave the configured ceilings unchanged.
Binary size checks passed✅ 7 passed
Generated by |
1 participant
Adopted from CI run
6951c866434f7ab480162b38483a2d54a76c6529.Binary size checks passed
✅ 7 passed
baml-clipacked-programbaml-clipacked-programbridge_wasmbaml-clipacked-programGenerated by
cargo size-gateSummary by CodeRabbit