Fix Rust and C++ release verification regressions#4118
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughC++ SDK smoke builds explicitly select ChangesSDK verification
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant platform_matrix
participant platforms_json
participant verify
participant consumer_main
platform_matrix->>platforms_json: Read release platform metadata
platforms_json-->>platform_matrix: Return eligible verification entries
platform_matrix->>verify: Supply JSON matrix
verify->>consumer_main: Run Rust consumer checks
consumer_main->>consumer_main: block_on rt_int_async
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8).github/workflows/verify-cpp-sdk.reusable.yamlTraceback (most recent call last): Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/verify-rust-sdk.reusable.yaml:
- Around line 53-54: Add a job-level permissions block to platform-matrix
granting only contents: read, ensuring the job can check out the repository
without inheriting broader token permissions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 27ff2dcc-ab5f-4e56-a410-0deb5b2216a4
📒 Files selected for processing (5)
.github/workflows/verify-cpp-sdk.reusable.yaml.github/workflows/verify-rust-sdk.reusable.yamlbaml_language/sdks/cpp/bridge_cpp/include/baml/variant.hbaml_language/sdks/cpp/bridge_cpp/tests/run.shbaml_language/sdks/rust/verify/consumer_main.rs
Binary size checks passed✅ 7 passed
Generated by |
Summary
runtime_smokeCMake target so verification does not compile unused full protobuf targetsFixes the Rust and C++ failures in https://github.com/BoundaryML/baml/actions/runs/29884885305.
Testing
actionlint .github/workflows/verify-rust-sdk.reusable.yaml .github/workflows/verify-cpp-sdk.reusable.yamlRUSTC_WRAPPER= cargo test -p baml_release platforms --locked(9 passed)baml::variantC++17 compile smokeruntime_smokeCMake targetSummary by CodeRabbit
runtime_smoketarget for Unix/musl/Windows, running the Release binary on Windows.main.