feat(webapp-graphql-relay): add route query lifetime ownership - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadRouteQuery({ lifetime })the lifetime-first API while preserving the deprecated raw-abortSignalcompatibility overload@omgjs/labkit-webapp-graphql-relay(expected 3.1.0)Why
A TanStack loader abort can retire loader ownership while React still presents the previous route during Suspense or pending navigation. Passing that signal directly to
loadRouteQuerycan therefore dispose a Relay preloaded query reference that still has a mounted consumer.The new lifetime separates loader ownership from mounted ownership and disposes the query only after the final owner releases it. TanStack routing, cache policy, route definitions, and generated operations remain application-owned.
Compatibility and customer impact
The existing
LoadRouteQueryOptions<TQuery>raw-signal type and behavior remain available for abort-only work and are deprecated. Mounted-route wrappers can migrate toLoadRouteQueryLifetimeOptions<TQuery>. The lifetime and raw signal inputs are mutually exclusive, with both TypeScript and runtime validation.The upgrade guide includes npm/pnpm commands, single- and multi-query migration, preload/history/retry rules, Strict Mode and Suspense behavior, and final teardown.
Validation
origin/maingit diff --checkPackage versions and changelogs are intentionally left to Rush Delivery after merge.