docs(registry): correct what a refused CORS origin leaves behind - #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No related issue. PR #173's merge took the branch head from before its last review round, so these five commits are on the branch and not on
main. They are that round's three documentation fixes plus the test that pins one of them.Changes
index.tsno longer claim the service logs no requests: the error handler logs every 5xx with its method and path, and what actually holds is that no log line names the origin.config.tsrecords why a permissiveCORS_ORIGINSdefault is bounded: the service authenticates no client, so the list decides which pages a browser hands a response to, never who may ask for one.Acceptance criteria
Test plan
Automated tests
246 registry unit tests in 11 files (was 245); 80 Daml scenarios in 12 modules; 18 e2e in 4 files against a live participant on Canton 3.5.12. Lint, both typechecks,
check:depsandsmoke:registryall clean.Manual verification
The new test earns its place by the one mutation that separates it from
errors.test.ts: addingorigin: req.headers.originto the 5xx log line reds only the new test, while dropping the log line or its method and path reds pre-existing tests too. A 24-mutation battery over the CORS layer andparseOriginsreds every guard discriminatingly and found no correctness bug insrc/.Breaking changes
None.
Checklist
Screenshots
None.