ci: check the npm package installs and the manifests agree - #168
Merged
Merged
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #162
CI had two jobs and neither ran a root
npm install, so nothing compiled the service against the dependency set a consumer gets and nothing checked that the published package installs. A third check,package, does both.Changes
packagejob: an ungatedgit check-ignoretable, then a scope gate,npm run check:deps,npm ci,npm run smoke:registry.registry/.gitignoreleave all seven coverage verdicts green while npm applies them to the pack walk, taking the tarball from 24 entries to 8 with the bin target among the losses.registry/, both new scripts,.gitignore,.npmrcandci.yml, none of which the two existing gates hold.damljob's own reasoning.Acceptance criteria
.gitignore, and every gated step is blind to it, since narrowingregistry/**/distback toregistry/dist(the regression7d04a6cfixed) leavescheck:depsandsmoke:registryboth at exit 0. The ungated step ahead of the gate is what holds it.check:depsbeforenpm ci, not after: it reads four tracked JSON files and needs nonode_modules, andnpm ciis no second reading of what it names, reddening only where the lockfile can no longer satisfy the range beside it.Test plan
Automated tests
Existing suites untouched; this adds a check rather than a test.
Manual verification
Every step body extracted from the committed YAML and run. The gate was driven end to end on ten single-file branch shapes (correct on all ten), and its regex over a fixed list of 12 paths that must match and 17 that must not.
Eleven mutations: the ignore rule reds when narrowed, deleted, over-broadened, or pointed at
registry/src;check:depsreds on a drifted range;InstallredsTS2307on an import onlyregistry/node_modulesresolves, which theregistryjob compiles green; the smoke reds when a nested ignore file empties the tarball.Six more for the placement assertion: it reds when the rule moves into
registry/.gitignoreas**/distor as baredist, and when a nested duplicate is added beside a kept root rule, all three of which were green before it and all three of which pack 8 files instead of 24; it stays green when an unrelated rule is added to either ignore file; and outside a git repository it reports the tool error rather than a verdict, with the step still exiting 1.Also measured, and now what the reordering comment says:
npm ciinstalls clean on a range the lockfile still satisfies (rootexpresswidened to^4.21.0against a locked 4.22.2) and redsEUSAGE, lock file's express@4.22.2 does not satisfy express@5.2.1only on the incompatible one, whilecheck:depsreds on both.Cold clone in the shipped order: all green, tree clean.
Breaking changes
None. No
required_status_checksrule exists, so the new context is advisory.Checklist
Screenshots
None.