feat: vest a canton-token-forge instrument instead of canton coin - #199
Open
lmcorbalan wants to merge 66 commits into
Open
feat: vest a canton-token-forge instrument instead of canton coin#199lmcorbalan wants to merge 66 commits into
lmcorbalan wants to merge 66 commits into
Conversation
build: vendor the canton-token-forge and vesting DARs
build: add the canton-token-forge registry service as a dev dependency
…E.md's bootstrap bullet
…vesting operator and factory
feat(scripts): seed the DBT instrument admin and config in bootstrap
…real process on down
…t URL and hide the bearer
feat(scripts): deploy the vendored DARs and run the token registry on 3013
…start to its port
feat: add the token-forge side alongside the Canton Coin one
…e vesting factory
…he deployment seam
feat(frontend): learn the instrument from the registry and move to the vesting factory
feat(frontend): move the vesting choices onto the instrument config
…ole-holding pledges
feat(frontend): select token holdings instead of splitting, and add the faucet tap
feat: forward the registry routes from the deployed origin
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
chore: merge main into the token-forge migration branch
…y production build
…close the rest of the review
Main had moved the root tooling into kit/, added the npm publish flow and the version lockstep check. This branch had removed the Daml package. Eight files conflicted. - package.json: main's script block, minus build-dar - knip.json: both ignore lists, minus the dapp/daml workspace entry - dapp/daml/package.json: kept this branch's deletion - CLAUDE.md, architecture.md, README.md, dapp/frontend/README.md: main's kit/ and publishing prose, this branch's DBT and vendored DAR prose - pnpm-lock.yaml: regenerated rather than hand-merged Main also deleted @mermaid-js/mermaid-cli, which this branch still named in knip.json, pnpm-workspace.yaml and CLAUDE.md. Two things the merge left pointing at files that no longer exist: - scripts/lib/gate.mjs moved to kit/gate.mjs. Every importer is in kit/ now, so it has to leave with that folder. - kit/manifests.mjs and kit/release-version.test.mjs named dapp/daml. The consumer scaffold section of CLAUDE.md described a six-entry deletion list and promised no file rewriting. The installer deletes seventeen paths and also strips seven scripts and two devDependencies from package.json, so the section now points at source/stacks/canton.ts as the list. postcss leaves knip's ignoreDependencies for the same reason: the installer removes the dependency.
Dropping it was wrong. The installer removes the dependency today, so the entry is redundant, but knip reports an unused devDependency as an error and not a hint. Keeping the entry costs one configuration hint and saves a consumer tree from failing the day the installer stops removing postcss. The reason is now written out where the scaffold rules are, instead of pointing at a paragraph that no longer explained it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #157
Canton Coin tied every write to Splice reference data:
AmuletRules, an open mining round and awallet-service tap. The dApp now vests a
DBTtoken-forge instrument through oneInstrumentConfigfrom a CIP-56 registry, which drops the Daml toolchain from the repository and grant creation to a
single wallet approval.
Changes
DBTtoken-forge instrument; Canton Coin vesting is removed, not kept alongsidedpmis no longer requireddev-stack.shruns the canton-token-forge registry on 3013 andbootstrapseeds the instrumentInstrumentConfigdisclosure, so a grant costs one approvalDBTfrom the dashboard headerDeviations
mainand conflicts in 33 files; integrating it is a separate passarchitecture.mdkeeps thedarnode and theAmuletRulesedge against Sweep the Canton Coin path out of the docs #186: both are still true/pending, not the dashboard, which renders no pending grantsREADME.mdwas authorized for Delete dapp/daml and the Canton Coin path #156, against the standing guardrailAcceptance criteria
DBTend to enddpmis not required to run the repositoryAmuletRulesor mining round reaches a writeTest plan
Automated tests
pnpm installpnpm lint,pnpm typecheck,pnpm build,pnpm test,pnpm knip,pnpm docs:checkandpnpm run check:anatomyfrom the repo rootdapp/frontendat 223 testsManual verification
./scripts/dev-stack.sh upand wait for 3010, 3012 and 3013 to answerDBTbalance to rise by 1000/pendingas the funder, cancel a grant, and expect its reserved holdings back in the balanceBreaking changes
pnpm run build-daris gone; both DARs ship undervendor/andpnpm run deploy-dar -- <dar>uploads themVITE_WALLET_RPC_URLis replaced byVITE_REGISTRY_URL, and a deployment also needsREGISTRY_URLpointing at a reachable registryChecklist
Screenshots
To be added before review.