feat(dapp): let a funder cancel and a receiver decline an unaccepted grant - #197
Merged
lmcorbalan merged 9 commits intoSep 9, 2026
Merged
Conversation
…tton its own name
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…in the party it submits as
… dialog tied to its own grant
… grant being ended twice
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #181
An unaccepted grant could not be ended from either side, so the holding it reserved stayed out of the funder's balance for good. Both parties now have a way out.
Changes
Deviations
Acceptance criteria
Test plan
Automated tests
pnpm installpnpm -C dapp/frontend testpnpm lint,pnpm typecheck,pnpm build,pnpm test,pnpm knip,pnpm docs:checkandpnpm run check:anatomyManual verification
./scripts/dev-stack.sh upand connect a funder wallet on http://localhost:3012localStorage, expect neithervesting.tokenDisclosuresnorvesting.tokenReadMissesto still name the ended grants' holdingsBreaking changes
None.
Checklist
Screenshots
To be added before review.