Skip to content

Ship the licence in release tarballs #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zenofex merged 1 commit into from
Oct 7, 2026
Merged

Ship the licence in release tarballs #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/cli-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,16 @@ jobs:
mkdir -p dist
cp target/${{ matrix.target }}/release/bootintel dist/
cp README.md dist/
cp ../LICENSE dist/ 2>/dev/null || echo "LICENSE not found at repo root; skipping"
# LICENSE, not ../LICENSE. The step runs at the repo root, so the old
# path pointed outside the checkout, never matched, and the
# `2>/dev/null || echo skipping` turned that into a log line nobody
# read. Every release from here back shipped with no licence file
# while this workflow's header claimed it bundled one, and Apache 2.0
# section 4(a) requires giving recipients a copy with the work.
#
# No fallback now: if the licence is missing the release should fail,
# because a silent skip is what hid this.
cp LICENSE dist/
tar -czf ${{ matrix.asset_name }} -C dist .

- name: Package (Windows)
Expand All @@ -177,7 +186,10 @@ jobs:
New-Item -ItemType Directory -Force -Path dist | Out-Null
Copy-Item "target\${{ matrix.target }}\release\bootintel.exe" -Destination "dist\"
Copy-Item README.md -Destination "dist\"
if (Test-Path "..\LICENSE") { Copy-Item "..\LICENSE" -Destination "dist\" }
# Same bug, same reason: ..\LICENSE is outside the checkout, and the
# Test-Path guard made the miss invisible. Unguarded now so a missing
# licence fails the build.
Copy-Item LICENSE -Destination "dist\"
Compress-Archive -Path "dist\*" -DestinationPath ${{ matrix.asset_name }}

- name: Compute SHA256
Expand Down
Loading