Repository navigation
Give each submit test its own log file - #39
Merged
Merged
Conversation
#37 shipped a race. Every test in submit_cli.rs wrote the same `tmpdir()/boot.log`, Rust runs tests in parallel threads, and `fs::write` truncates before it writes. So one test's spawned process could read the file in the instant another test had emptied it, and the binary did exactly what it should: "boot.log is empty; nothing to submit". It passed 7/7 locally and passed on main's own CI run, then failed `test (default-features)` on the next branch. That is the shape of flake that survives: red often enough to erode trust in the suite, green often enough that nobody can reproduce it. Each test now writes its own `<tag>.log`. Verified with 15 consecutive runs of the file, 0 failures, and seven distinct files on disk. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#37 shipped a race, and it blocked #38.
Every test in
submit_cli.rswrote the sametmpdir()/boot.log. Rust runs tests in parallel threads, andfs::writetruncates before it writes, so one test's spawned process could read the file in the instant another had emptied it. The binary then did exactly what it should:It passed 7/7 locally and passed on main's own CI run, then failed
test (default-features)on the next branch. That is the shape of flake that survives: red often enough to erode trust in the suite, green often enough that nobody can reproduce it.Each test now writes its own
<tag>.log.Verified with 15 consecutive runs of the file — 0 failures — and seven distinct files on disk.
🤖 Generated with Claude Code