Repository navigation
Release 0.4.0 - #3
Merged
Merged
Conversation
Ships the correctness batch. The reason this is urgent: v0.3.1 is still what downloads/bootintel.com and the GitHub release page hand people, and it contains the --log-file bug that writes zero bytes unless the session exits through the clean path. Anyone capturing today can lose the whole log while believing they have it. The fix has been sitting on main unreleased. Numbered 0.4.0, not 1.0.0. The project's own policy calls an exit-code change MAJOR and this batch changes one, but the crate is pre-1.0, so the leading zero is the major component and a breaking change moves the minor. Releasing 1.0.0 would assert an API-stability commitment this project has not made. The rationale is recorded in the changelog so the next reader does not have to re-derive it. Callers upgrading a CI job should read the exit-code note: scan now exits 2 for an empty or unusable capture and 3 when nothing was recognized, where it previously exited 0 for both. That is the point of the change, since a job whose UART never came up used to report green. Verified: 274 tests pass, clippy clean under -D warnings, rustfmt clean, and cargo audit reports no vulnerabilities. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ships the correctness batch that is currently merged but unreleased.
Why this is urgent.
cli-v0.3.1is still what the release page and the site hand people, and it contains the--log-filedefect that writes zero bytes unless the session exits through the clean path. Anyone capturing today can lose the entire log while believing they have it.Why 0.4.0 and not 1.0.0. The versioning policy in CHANGELOG.md calls an exit-code change MAJOR, and this batch changes one. But the crate is pre-1.0, so the leading zero is the major component and a breaking change moves the minor. Publishing 1.0.0 would assert an API-stability commitment this project has not made. The reasoning is recorded in the changelog rather than left implicit.
Breaking for CI consumers.
scannow exits 2 for an empty or unusable capture and 3 when nothing was recognized, where it previously exited 0 for both. That is deliberate: a job whose UART never came up, whose adapter fell out, or whose artifact path was wrong used to report green.Verified locally: 274 tests pass, clippy clean under
-D warnings, rustfmt clean,cargo auditreports no vulnerabilities.After merge, the release workflow is dispatched manually with version
0.4.0, then the tag is cut from the released commit per the workflow's documented process.