gate rollout: cf-import-contract joins the reusable quality gate#5
Merged
Conversation
…rge LAST)
Executes the rollout deliberately deferred in the gate's build PR ("Open
fork for the maintainer") and since ratified by the maintainer via ADR
0030: the reusable quality-gate.yml now runs cf-import-contract --root .
against the consumer tree, in the same battery position as self-ci
(after cf-exemptions, before the mypy ratchet) and with the same typed
semantics — exit 1 is a violation verdict (CONTRACT_MISSING for a repo
with no committed contract), exit 2 is the gate itself failing to run
(typed GateError; environment trouble is never a violation verdict).
test_gate_runs_full_battery_in_order re-anchors honestly: the pinned
battery now names cf-import-contract in its position.
Blast radius: a consumer repo running this workflow without a committed
import contract fails CONTRACT_MISSING from the moment its pin reaches
this commit — this change merges LAST, after every mounted repo's
contract PR.
Full self-ci battery green locally in a fresh venv (ruff check + format,
sticky, file-budget, recursion, exemptions, import-contract exit 0,
mypy 0 issues, 310 passed).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Mounts the
cf-import-contractstep into the reusablequality-gate.yml— the consumer-facing battery — modeled exactly on the self-ci step: same command shape (cf-import-contract --root ., run from the consumer root), same battery position (aftercf-exemptions, before the mypy ratchet), same typed-error semantics (exit 1 = violation verdict; exit 2 = the gate itself could not run — typedGateErroron stderr, environment trouble is never a violation verdict).This executes the fork deliberately left open in the gate's build PR (#2, "Open fork for the maintainer: mounting it into the reusable quality-gate.yml would immediately fail every consumer repo that has not yet committed a contract"). The maintainer has now ratified the rollout via ADR 0030; this PR is the execution.
test_gate_runs_full_battery_in_orderre-anchors honestly: the pinned battery list now namescf-import-contractin its position. Diff is 10 lines across 2 files.Blast radius — MERGE LAST
Merge LAST, after every mounted repo's contract PR — a consumer repo running this workflow without a committed import contract fails CONTRACT_MISSING from the moment its pin reaches this commit (and consumers that check out the kit unpinned at main are affected immediately on merge).
Known consumer defect (by description, flagged in the overnight burn's harvest): one consumer repo's caller checks out the kit at main rather than a pinned SHA, against the SHA-pin doctrine — that repo feels this gate the instant this PR merges, regardless of its own pin discipline. Heal its pin (or land its contract) before merging here.
Verification
Full self-ci battery green locally in a fresh venv (
pip install -e '.[dev]'):ruff check · ruff format --check · cf-sticky-check check . · cf-file-budget · cf-recursion-check · cf-exemptions · cf-import-contract --root . → exit 0 (the kit's own contract holds) · mypy src (0 issues) · pytest 310 passed.
Anta merges; nothing auto-merges.
🤖 Generated with Claude Code