bug: Parlor light ships wrong window_hint/ext_pink/accent_pink color (#e24394 vs spec #e2438e)#18
Merged
Antawari merged 1 commit intoJun 14, 2026
Conversation
…438e The Parlor (light) theme documented its window_hint as "deepened pink #e2438e" (CLAUDE.md §5), whose blue channel byte is 0x8e = 0.556863. The shipped RON instead set window_hint, ext_pink, and accent_pink all to blue: 0.580392 (0x94 = #e24394), and the light accent-palette pink entry copied the same value. 0.580392 is byte-identical to the mint/success blue channel — a copy-paste artifact that deepened pink toward mint's blue instead of the documented pink blue, so the focused-window outline rendered the wrong pink. Fix: blue 0.580392 -> 0.556863 on all three parlor-light lines (49, 60, 92) and accent-palette-light entry 1, keeping the two files in lockstep (the accent suite pins entry 1 to the window_hint role). Adds a spec-anchored RON guard test that extracts the #e2438e hex from CLAUDE.md §5, converts its blue byte to the repo's float convention, and asserts all four pink sites carry it and none collide with the mint blue channel. Verified RED on the old value, GREEN on the fix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Antawari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CLAUDE.md §5 documents the Parlor (light)
window_hintas deepened pink#e2438e(blue channel byte0x8e=0.556863). The shipped RON instead setwindow_hint,ext_pink, andaccent_pinkall toblue: 0.580392(0x94→#e24394), andthemes/candyfactory-accent-palette-lightentry 1 (pink) copied the same wrong value.0.580392is byte-identical to the mint/success blue channel (success:/ palettegreen:) — a copy-paste artifact: it deepened pink toward mint's blue instead of the documented pink blue. The focused-window outline on the Parlor theme therefore rendered a different pink than spec.Falsifiable claim it satisfies
Before: all four pink sites carried
blue: 0.580392→0x94→#e24394(REFUTED).After: all four carry
blue: 0.556863→0x8e→#e2438e(matches spec).Change
themes/candyfactory-parlor-light.ronlines 49 (ext_pink), 60 (accent_pink), 92 (window_hint):blue 0.580392 → 0.556863.themes/candyfactory-accent-palette-lightentry 1 (pink): same. Kept in lockstep with the parlor-lightwindow_hintrole — the existing accent-palette suite pins entry 1 to that role, so both files must move together.tests/test_theme_rons.sh: new spec-anchored guardtest_parlor_pink_matches_claudemd_spec. It extracts the#e2438ehex from CLAUDE.md §5's Parlor (light)window_hintrow (the unfoolable oracle), converts its blue byte to the repo's 6-decimal float convention, and asserts all four pink sites carry it and that none collide with the live mint blue channel.TDD
0.580392—ext_pink blue 0.580392 != spec pink blue 0.556863 (#e2438e); mint-blue copy-paste artifact?0.556863.THEME_DIRscratch indirection against buggy copies → FAIL, on the fixed files → PASS.Full gate (per
.github/workflows/checks.yml)install.sh tests/*.sh— cleantests/test_accent_palettes.sh— 14/14 (incl.test_light_palette_pink_matches_window_hint, the lockstep guard)tests/test_theme_rons.sh— 14/14 (new test green)tests/test_install.sh— 7/7No existing test weakened, skipped, or deleted. No exemptions added.
DO NOT MERGE — fleet quality burn; the user gates merge.
🤖 Generated with Claude Code