Skip to content

added fix for newly installed plugins / themes - #370

Open
jamesros161 wants to merge 4 commits into
masterfrom
last-minute-fixes
Open

added fix for newly installed plugins / themes#370
jamesros161 wants to merge 4 commits into
masterfrom
last-minute-fixes

Conversation

@jamesros161

@jamesros161 jamesros161 commented Aug 13, 2020

Copy link
Copy Markdown
Contributor

If you install a new plugin or new theme and change the settings using WP Auto Update UI, the changes do not take effect in boldgrid backup settings because the plugin / theme does not already exist in those settings. This update addresses that issue.


Note

Low Risk
Narrow settings-sync bug fix on option update hooks; no changes to backup, restore, or authentication paths.

Overview
Fixes Total Upkeep auto-update settings staying out of sync when you enable auto-updates in the WordPress 5.5+ UI for a plugin or theme that was just installed and does not yet have an entry in Total Upkeep’s stored auto_update map.

wordpress_option_updated() still walks existing settings keys to turn offers on or off from auto_update_plugins / auto_update_themes, and now also loops the enabled offers from WordPress and writes '1' for any slug that was missing locally. The default key behavior is unchanged (only touched by the first loop).

readme.txt only normalizes changelog formatting for the 1.14.3 release date line.

Reviewed by Cursor Bugbot for commit 8c23c90. Bugbot is set up for automated code reviews on this repo. Configure here.

@jamesros161
jamesros161 requested a review from bwmarkle August 13, 2020 18:24
@codecov-commenter

codecov-commenter commented Aug 13, 2020

Copy link
Copy Markdown

Codecov Report

Merging #370 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #370      +/-   ##
============================================
- Coverage     25.70%   25.70%   -0.01%     
- Complexity     2857     2858       +1     
============================================
  Files           199      199              
  Lines         14390    14392       +2     
============================================
  Hits           3699     3699              
- Misses        10691    10693       +2     
Impacted Files Coverage Δ Complexity Δ
admin/class-boldgrid-backup-admin-auto-updates.php 82.92% <0.00%> (-2.08%) 36.00 <0.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a15c6e2...cff5de6. Read the comment docs.

bwmarkle
bwmarkle previously approved these changes Aug 13, 2020
@cssjoe

cssjoe commented Aug 3, 2026

Copy link
Copy Markdown
Member

Status update (Aug 2026 triage): Still open and still relevant — wordpress_option_updated() on master still only updates offers already present in Total Upkeep auto-update settings, so newly installed plugins/themes enabled via WP’s UI can be missed. Needs rebase and re-review before merge.

@cssjoe
cssjoe requested a review from a team September 1, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants