invoker: don't show output of captured commands by default#701
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #701 +/- ##
==========================================
- Coverage 89.25% 89.24% -0.01%
==========================================
Files 50 50
Lines 16446 16450 +4
==========================================
+ Hits 14679 14681 +2
- Misses 1767 1769 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Apparently, adding the dependency in setup.py is not supported anymore.
Capturing the output (stdout and/or stderr) of a command and the visibility of the output streams to the user used to be independent options. This is confusing, though. If the output is captured, it means that it is coming from some redirected, Bob-internal command. The user is unaware what command that is and will just observe random output. To make it more understandable, show the redirected output only if the command is traced. Fixes BobBuildTool#699.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capturing the output (stdout and/or stderr) of a command and the visibility of the output streams to the user used to be independent options. This is confusing, though. If the output is captured, it means that it is coming from some redirected, Bob-internal command. The user is unaware what command that is and will just observe random output.
To make it more understandable, show the redirected output only if the command is traced.
Fixes #699.