Add SOT target control and state telemetry with image dimensions#265
Open
jp-pino wants to merge 9 commits into
Open
Add SOT target control and state telemetry with image dimensions#265jp-pino wants to merge 9 commits into
jp-pino wants to merge 9 commits into
Conversation
Add SetSotTargetCtrl to control.proto for setting/clearing SOT targets. Add SotState message format with State enum (IDLE/TRACKING/LOST). Add SotStateTel to telemetry.proto for reporting tracking state. Zero-size bounding box (width=0, height=0) convention clears the target. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add image_width and image_height fields to SotState so receivers know the frame resolution the bounding box coordinates are relative to. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add image_width and image_height so the receiver can rescale bounding box coordinates from the app's frame to the model's actual source resolution. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
follesoe
approved these changes
May 8, 2026
Member
follesoe
left a comment
There was a problem hiding this comment.
Du we need a message to clear the Sot tracking?
Add CvModelInfo protobuf message with name, type, running, device, and package_id fields. Add repeated cv_models field to DroneInfo for reporting loaded computer vision models in telemetry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
follesoe
approved these changes
May 13, 2026
Include the full list of class names the model can detect, indexed by class_id, in the DroneInfoTel telemetry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preferred way to clear the SOT target (stop tracking). The zero-size bounding box in SetSotTargetCtrl still works for backwards compatibility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for single-object tracking (SOT) to the protocol buffers used by the system. The changes introduce new messages for controlling, reporting, and telemetering the SOT state, allowing external clients to set tracking targets and receive updates on the tracking process.
Single-object tracking (SOT) support:
SetSotTargetCtrlto allow clients to set or clear the SOT target by specifying a bounding box and frame dimensions.SotStatemessage, which reports the current state of the SOT tracker, including the tracked bounding box and frame size. This includes an enum for tracker states (idle, tracking, lost, etc.).SotStateTelto periodically report the current SOT state and bounding box from the computer vision pipeline.