Add SetLogFrequencyReq/Rep messages for logging frequency configuration#258
Open
jp-pino wants to merge 2 commits into
Open
Add SetLogFrequencyReq/Rep messages for logging frequency configuration#258jp-pino wants to merge 2 commits into
jp-pino wants to merge 2 commits into
Conversation
…ing frequency updates
jp-pino
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new request/reply protobuf messages to allow SDK clients to configure telemetry logging frequency independently of publish frequency, aligning with the existing SetPubFrequencyReq/Rep pattern.
Changes:
- Introduced
SetLogFrequencyReqto set per-message logging frequency (max 100 Hz). - Introduced
SetLogFrequencyRepto report success/failure of the logging frequency update.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
follesoe
approved these changes
Apr 29, 2026
jp-pino
force-pushed
the
jp-pino/set-log-frequency
branch
from
c3c8abf to
598656b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These new messages follow the same pattern set by
SetPubFrequencyReq/Rep, which only modifies publish frequency but doesn't affect the logging rate. They will enable SDK users to modify the logging frequency independently from the publish frequency, for later use in post processing.The same guardrails will apply as normal. Duplicated messages won't be logged, and the max logging frequency would be 100 Hz.
Related to https://github.com/BluEye-Robotics/p2_drone/issues/961