Add saving lazyudf - #532
Merged
Merged
Conversation
FrancescAlted
left a comment
FrancescAlted
left a comment
Member
There was a problem hiding this comment.
Good work! I am just wondering if we can still use the commented out code that checks for special values. I don't remember if there is some benchmark that exercises this code, but it could well be the case. Can you double chek that?
Collaborator
Author
|
There are benchmarks for filling/accessing schunks with special values, but none for lazy expression calculations which use operands with special values, which is the context in which the commented-out code would be executed. |
FrancescAlted
self-requested a review
November 27, 2025 14:06
FrancescAlted
approved these changes
Nov 27, 2025
FrancescAlted
left a comment
FrancescAlted
left a comment
Member
There was a problem hiding this comment.
LGTM. In case we are not going to need the commented code here, better remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to fully implement ironArray/Caterva2#279, need this PR which adds a
savemethod toLazyUDFclass in blosc2.Also fixes #533