Repository navigation
stl2step 1.8.0: corner spheres, closed hub rings, seam-safe partial cylinders - #28
Merged
Merged
Conversation
…inders - A corner where three certified rounds meet ships as one sphere: the centre is taken from the anchoring rounds (cylinders or a certified torus), the radius is fitted, and the sphere ships only when every vertex and every sphere|round contact is within the mesh tolerance. An uncertified cylinder whose every triangle lies in that sphere's preimage is dissolved into it. - A closed coaxial wall may carry windows; a fold-free closed wall anchored by a certified tangent parallel cylinder is lifted as one closed cylinder, and the rounds that anchor it are refitted exactly tangent to it with a common generator at their corner. - A region whose vertices all lie on a certified member of a coaxial family takes that member's surface; edge-adjacent re-hosts join by closure. - A single certified partial cylinder runs the same-surface whole-turn fill as a merged group does; a certified region whose face build fails reports its BRepCheck status under STL2STEP_DIAG_REL instead of being dropped silently. - A partial cylinder face that fails BRepCheck because its trim touches the periodic seam is rebuilt on the same cylinder with its frame rotated so the trim is centred at pi (heal only; a face valid at its first build is never touched). - Gates: the partial-recovery gate's sphere count is an exact ratchet for the certified corner spheres (5 shipped, 9 in the ground truth); its volume ceiling is the measured three-platform maximum. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UTMvXaSuW29sDT7knjDitW
AGENTS.md: TrueForm also recovers chamfer cones and anchored tori and corner spheres; only unanchored cones, spheres and tori stay faceted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UTMvXaSuW29sDT7knjDitW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TrueForm 1.8.0 (task stl2step-fc, phase fc-8, the handle-pickup round). See CHANGELOG.md [1.8.0].
Local CI on 6cfcfa9: macOS fresh clone, Linux and Windows 114/114.
🤖 Generated with Claude Code
https://claude.ai/code/session_01UTMvXaSuW29sDT7knjDitW