Repository navigation
tooling: ci-windows-preflight stops shipping the Mac baseline build to the node - #26
Merged
Merged
Conversation
…o the node The tests/ entry list pruned tests/gates/baseline/.build and .worktree-* but still printed every directory, and tar recursed into tests/, tests/gates/ and tests/gates/baseline/, re-adding both trees. The node cleanup then removed the synced .build only when its CMakeCache contained '/Users/', which a worktree outside /Users (a /private/tmp scratchpad) does not. Result, measured on 5861814: G0.1 XFAIL "baseline cannot be built" on every fixture, and G0.3 fell back off its 187ead0 twin to the own off-path run and failed on cross_bores (force-sew exit 2 != off-path exit 0), while macOS and Linux passed 105/105. - tests/ is listed as files and symlinks only, so tar has no directory to recurse into. On a tree carrying both artifacts the archive drops from 80 baseline paths to 0, with every tracked test file still present. - The node removes repo/tests/gates/baseline/.build whenever it exists: repo/ is recreated every run, so anything there came from the Mac. Linux is unaffected (rsync with anchored excludes). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UTMvXaSuW29sDT7knjDitW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tooling only. No engine, test or CMake change.
Problem
scripts/ci-windows-preflight.shships the working tree to the Windows node withtar. Itstests/entry list prunedtests/gates/baseline/.buildand.worktree-*, butfind … -prune -o -printalso prints every directory (tests,tests/gates,tests/gates/baseline, …).tarrecursed into each one and re-added both trees.The node-side cleanup then removed a synced
.buildonly if itsCMakeCache.txtcontained/Users/. That holds for a checkout under the home folder, but not for a worktree elsewhere (e.g./private/tmp/…, which CMake records as/tmp/…).Measured while validating #25 (5861814): the Mac cache reached the node, so
build_baseline.shfailed. G0.1 went XFAIL ("baseline cannot be built") on every fixture, and G0.3 fell back off its 187ead0 twin to the candidate's own off-path run. It then failed oncross_bores(force-sew exit 2 != off-path exit 0). macOS and Linux were 105/105 on the same sha, and a rerun from a never-built worktree was 105/105 on Windows.Change
tests/is listed as files and symlinks only (-type f -o -type l), sotarhas no directory to recurse into.tarcreates parent directories on extract, and git tracks no empty ones.repo/tests/gates/baseline/.buildwhenever it exists.repo/is recreated every run, so anything there came from the Mac.Linux is unaffected: its preflight syncs with
rsyncand anchored excludes.Verification
git ls-files testspath is still present..build(cache recorded under/tmp/…) was planted in this branch's worktree and the fixed preflight run from it. Result: no cleanup line fired (nothing was shipped), 0 baseline-build errors,gates_fullpassed, 104/104.🤖 Generated with Claude Code
https://claude.ai/code/session_01UTMvXaSuW29sDT7knjDitW