feat(statics): support tokens on dynamically onboarded EVM chains#8717
Merged
shubham-damkondwar merged 1 commit intomasterfrom May 8, 2026
Merged
Conversation
Two gates in statics silently dropped tokens for chain families not
present at module load time:
- Gate 1: networkFeatureMapForTokens only covered static CoinFamily
values. Added registerNetworkTokenFeatures() and
getNetworkTokenFeatures() to allow runtime registration of token
features for new families. createTokenMapUsingTrimmedConfigDetails
- Gate 2: erc20ChainToNameMap was built once from static coins, so
dynamic families were absent from both initializerMap and the switch
case routing. Added a chainId-based check inside createToken: if the
token's network carries a numeric chainId (EVM indicator), the family
is added to erc20ChainToNameMap before the existing loop runs,
ensuring initializerMap[family] = erc20Token and the switch case
resolves correctly.
CECHO-952
TICKET: CECHO-952
shubham-damkondwar
force-pushed
the
CECHO-952/dynamic-evm-token-support-in-statics
branch
from
20a8d42 to
fa4f74e
Compare
nvrakesh06
approved these changes
May 8, 2026
manas-at-bitgo
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two gates in statics silently dropped tokens for chain families not present at module load time:
Gate 1:
networkFeatureMapForTokensonly covered static CoinFamily values.=> Added registerNetworkTokenFeatures() and getNetworkTokenFeatures() to allow runtime registration of token features for new families. createTokenMapUsingTrimmedConfigDetails
Gate 2:
erc20ChainToNameMapwas built once from static coins, so dynamic families were absent from initializerMap. Added a EVM compatibility check inside createToken: if the token's network is EVM compatible, the family is added toerc20ChainToNameMapbefore the existing loop runs, ensuring initializerMap[family] = erc20Token.TICKET: CECHO-952