feat(passkey-crypto): migrate encryption from SJCL to Argon2id v2#8714
Draft
feat(passkey-crypto): migrate encryption from SJCL to Argon2id v2#8714
Conversation
Replace synchronous SJCL-based encrypt/decrypt calls with async Argon2id v2 equivalents across attachPasskeyToWallet and removePasskeyFromWallet. - attachPasskeyToWallet: use decryptAsync + encryptAsync with encryptionVersion: 2 - removePasskeyFromWallet: use decryptKeychainPrivateKeyAsync instead of sync variant - derivePassword: update JSDoc to reflect Argon2id v2 password usage - Test mocks updated to support encryptAsync/decryptAsync with version-dispatching - Integration tests assert v2 envelope and use decryptV2 for round-trip verification - Unit tests add v2-specific coverage for both attach and remove flows - Bump package version to 0.3.0 and add @bitgo/sdk-api devDependency Ticket: WCN-412
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encrypt/decryptwith async Argon2id v2 equivalents (encryptAsync/decryptAsync) inattachPasskeyToWalletandremovePasskeyFromWalletencryptV2/decryptV20.3.0and adds@bitgo/sdk-apidevDependencyTest plan
yarn unit-test— 50 passingyarn integration-test— 56 passingTicket: WCN-412