fix: durable version single-source, gitignore typo, release tag-only trigger - #129
Merged
Merged
Conversation
- version dynamic from datamaxi/__version__.py (0.28.0); drops static dup - .gitignore __pycache___ -> __pycache__/ - release.yml runs only on v* tag pushes Closes #128
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #128
Three maintenance fixes from repo health scan.
1. Version drift (durable)
__version__.pywas0.26.3while pyproject/tags were0.28.0, so User-Agent (api.py:50) self-reported wrong version. Now single source of truth:datamaxi/__version__.py = 0.28.0, pyprojectversionis dynamic viaattr = datamaxi.__version__.__version__(AST-read, no package import). Future bumps can't drift.2. .gitignore
__pycache___(triple underscore, matched nothing) ->__pycache__/.3. release.yml
on: push->on: push: tags: ['v*']so wheel builds only on release tags. publish job'sstartsWith(refs/tags/)gate left intact.Test plan
python -m build --sdist->datamaxi-0.28.0.tar.gz(version resolves from single source)pytest -m 'not integration' -q: 134 passed, 11 skippedblack --check: clean;flake8: clean