Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of randomly picking LR genes - most of which are not found on sparse, single cell data, we test each spot against its co-detected pairs instead.
The
nullargument is added tost.tl.cci.runandperform_spot_testing:"codetected"(new default): only the random pairs that score above 0 at that spot are selected and p = (n_greater + 1) / (n_codetected + 1)"random"(previous default): alln_pairsare used and p = max(n_greater, 1) / n_pairs.For sparse data random pairs aren't detected at a given spot and score 0 - therefore any score above 0 looks significant - and unrelated genes maybe called. Co-detection brings that back to chance. The two nulls give nearly the same p-values when random is combined with gridding.
A fix for #374
Pay special attention to the following tests: