Skip to content

gdb-xml: add tricore.xml - #42

Merged
Rot127 merged 12 commits into
BinaryAnalysisPlatform:trace-10.0from
Starforge-Atelier:trace-10-tricore
Oct 24, 2025
Merged

gdb-xml: add tricore.xml#42
Rot127 merged 12 commits into
BinaryAnalysisPlatform:trace-10.0from
Starforge-Atelier:trace-10-tricore

Conversation

@b1llow

@b1llow b1llow commented Oct 20, 2025

Copy link
Copy Markdown

gdb-xml: add tricore.xml

link: BinaryAnalysisPlatform/bap-frames#29

@b1llow

b1llow commented Oct 23, 2025

Copy link
Copy Markdown
Author

Please take a look and see if there are any other areas that need revision.

@Rot127

@Rot127 Rot127 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just those nitpicks. Otherwise lgtm

static void plugin_exit(qemu_plugin_id_t id, void *udata) {
flush_all_frame_bufs();
qemu_plugin_outs("Exiting plugin, flushing data...\n");
// flush_all_frame_bufs();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document why it is commented out. Or even better, open an issue and link it here.
Also change the log message, because it doesn't flush the data anymore.

Comment thread gdb-xml/tricore-core.xml
@@ -0,0 +1,77 @@
<?xml version="1.0"?>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment here where you got it from or if you created it and with what reference. Also for the other xml files.

Comment thread configs/targets/tricore-softmmu.mak Outdated
@Rot127

Rot127 commented Oct 23, 2025

Copy link
Copy Markdown

Would you mind fixing the build error? Should be just a simple install of dependencies.

@b1llow
b1llow requested a review from Rot127 October 23, 2025 15:12
…(unused)) (#1)

Co-authored-by: b1llow <24983369+b1llow@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@b1llow
b1llow requested a review from Rot127 October 24, 2025 09:11
@Rot127

Rot127 commented Oct 24, 2025

Copy link
Copy Markdown

@b1llow Sorry, last thing. Can you please add TriCore to the "known to work" list in the main README.md?

@b1llow
b1llow requested a review from Rot127 October 24, 2025 15:10
@Rot127
Rot127 merged commit 62c5235 into BinaryAnalysisPlatform:trace-10.0 Oct 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants