ci: make the image security scan non-blocking - #35
Merged
Conversation
The Falcon API client is missing the scope for /csdownloads, so the FCS CLI cannot be installed and the scan fails before the image is published. OAuth succeeds against the same host, so the credentials and region are valid. Publish the image while the scope is sorted out, surfacing the scan result as a warning. Revert once the scan can run. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #34. Switching to the official
crowdstrike/fcs-actiongot a real error message out of the scan, and it is not a version problem — it is a permissions problem (run):The action authenticates first and only then requests the CLI. OAuth succeeded against
api.<region>.crowdstrike.com, soFALCON_CLIENT_ID,FALCON_CLIENT_SECRET, andFALCON_REGIONare all valid. What fails isGET /csdownloads/combined/files-download/v2, which returns anerrorsarray. The Falcon API client is missing the scope that allows downloading the FCS CLI.That also explains the original
exit code 6: the old shared action hit the v1 download endpoint, got nodownload_urlback for the same reason, and curl then tried to resolve a host literally namednull.This unblocks publishing while the scope is granted in the Falcon console:
continue-on-error: trueon the scan step.This is temporary and should be reverted once the API client has the download scope. The image is published without a passing scan in the meantime.
Test plan
v3.0.0release to re-firerelease: publishedghcr.io/bigdata-com/bigdata-risk-analyzer:v3.0.0and:latestare pushedMade with Cursor