Skip to content

Fix CI and release workflows #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigWebstas merged 1 commit into from
Oct 6, 2026
Merged

Fix CI and release workflows #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ jobs:

- name: Set up Android SDK
uses: android-actions/setup-android@v3
with:
# Default packages include the retired 'tools' package, which makes sdkmanager fail.
packages: ''

- name: Install Android SDK packages
run: |
Expand Down
12 changes: 9 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ jobs:
release:
name: Build & Publish Release
runs-on: ubuntu-latest
env:
# The secrets context isn't allowed in step-level `if:`, so expose it via env.
HAS_PLAY_KEY: ${{ secrets.PLAY_STORE_JSON_KEY != '' }}

steps:
- name: Checkout repository
Expand All @@ -45,6 +48,9 @@ jobs:

- name: Set up Android SDK
uses: android-actions/setup-android@v3
with:
# Default packages include the retired 'tools' package, which makes sdkmanager fail.
packages: ''

- name: Install Android SDK packages
run: |
Expand Down Expand Up @@ -136,7 +142,7 @@ jobs:
EXPECTED_FPRINT="3c7b738a4be737b5ed376eb686f9d507d4779d715e6d73a0306e2d7b7203852c"

FDROID_APK="dist/PebbleRecorder-${TAG}-fdroid.apk"
CERT_FPRINT=$(apksigner verify --print-certs "$FDROID_APK" | grep "SHA-256 digest:" | head -n1 | awk '{print $NF}')
CERT_FPRINT=$("$ANDROID_HOME/build-tools/37.0.0/apksigner" verify --print-certs "$FDROID_APK" | grep "SHA-256 digest:" | head -n1 | awk '{print $NF}')

echo "Expected certificate digest: $EXPECTED_FPRINT"
echo "Actual APK certificate digest: $CERT_FPRINT"
Expand All @@ -161,7 +167,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Publish to Google Play Store
if: ${{ (github.event_name == 'push' || inputs.publish_to_play) && secrets.PLAY_STORE_JSON_KEY != '' }}
if: ${{ (github.event_name == 'push' || inputs.publish_to_play) && env.HAS_PLAY_KEY == 'true' }}
uses: r0adkll/upload-google-play@v1
with:
serviceAccountJsonPlainText: ${{ secrets.PLAY_STORE_JSON_KEY }}
Expand All @@ -171,6 +177,6 @@ jobs:
whatsNewDirectory: distribution/whatsnew

- name: Notice on Google Play Upload
if: ${{ (github.event_name == 'push' || inputs.publish_to_play) && secrets.PLAY_STORE_JSON_KEY == '' }}
if: ${{ (github.event_name == 'push' || inputs.publish_to_play) && env.HAS_PLAY_KEY != 'true' }}
run: |
echo "::notice::Google Play upload was skipped because PLAY_STORE_JSON_KEY secret is not configured."
Loading