Skip to content

✨ Add appraisal#73

Open
pboling wants to merge 1 commit into
Betterment:mainfrom
VitalConnectInc:add-appraisal
Open

✨ Add appraisal#73
pboling wants to merge 1 commit into
Betterment:mainfrom
VitalConnectInc:add-appraisal

Conversation

@pboling

@pboling pboling commented Mar 3, 2025

Copy link
Copy Markdown
Contributor
  • test Matrix:
    • [ [Rails 6.1, 7.0, 7.1, 7.2, 8.0] x [Ruby 3.0, 3.1, 3.2, 3.3, 3.4] ]
  • loosen rubocop dep requirements
  • upgrade dependencies
  • lint updates
  • upgrade to actions/checkout@v4
  • add rubocop-packaging
  • fixes undeclared dependency on rubocop-factory_bot by adding it
  • allow rubocop-rspec v3
  • prefer YAML.safe_load_file

Replaces #63, #60

- test Matrix:
  - [
    [Rails 6.1, 7.0, 7.1, 7.2, 8.0]
    x
    [Ruby 3.0, 3.1, 3.2, 3.3, 3.4]
    ]
- loosen `rubocop` dep requirements
- upgrade dependencies
- lint updates
- upgrade to `actions/checkout@v4`
- add `rubocop-packaging`
- fixes undeclared dependency on `rubocop-factory_bot` by adding it
- allow `rubocop-rspec` v3
- prefer `YAML.safe_load_file`
@pboling

pboling commented Mar 3, 2025

Copy link
Copy Markdown
Contributor Author

@smudge This is ready for review!, let me know if you'd like anything split into a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant