Add fallback to 'lake env lean' when 'lake build' fails - #245
Open
alok wants to merge 3 commits into
Open
Conversation
This change modifies the Lean verification logic to automatically fall back to building individual files with 'lake env lean' when 'lake build' fails. Changes: - Modified verify_file() in language_tools.py to add fallback logic - Updated standalone formatting scripts for consistency - Tested and confirmed fallback works correctly
TheodoreEhrenborg
left a comment
TheodoreEhrenborg
left a comment
Contributor
There was a problem hiding this comment.
Do we have results on how much the extra lean command slows down vericoder.py (hopefully not much for larger models)? In general I like having the fallback because it should save us from forgetting to add folders to the lakefile. But also we need APPS train by tomorrow so I want vericoder.py to run as fast as possible
Maybe we should just replace lake build with lake env lean in all cases, so there's no slowdown?
Contributor
Author
|
It’s probably better for our case to do lake env over lake build. I don’t
think this will noticeably slow it
…On Thu, Sep 18, 2025 at 05:01 Theodore Ehrenborg ***@***.***> wrote:
***@***.**** commented on this pull request.
Do we have results on how much the extra lean command slows down
vericoder.py (hopefully not much for larger models)? In general I like
having the fallback because it should save us from forgetting to add
folders to the lakefile. But also we need APPS train by tomorrow so I want
vericoder.py to run as fast as possible
Maybe we should just replace lake build with lake env lean in all cases,
so there's no slowdown?
—
Reply to this email directly, view it on GitHub
<#245 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB7QUTAP35C6DBHMBFQTBSD3TJYHJAVCNFSM6AAAAACG2R4H5KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTEMZYGMZDENRRGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
Contributor
Author
|
I’m not sure it saves us because I think it uses lakefile to calculate what
it needs. I’ll test it
…On Thu, Sep 18, 2025 at 21:38 Alok Singh ***@***.***> wrote:
It’s probably better for our case to do lake env over lake build. I don’t
think this will noticeably slow it
On Thu, Sep 18, 2025 at 05:01 Theodore Ehrenborg ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
>
> Do we have results on how much the extra lean command slows down
> vericoder.py (hopefully not much for larger models)? In general I like
> having the fallback because it should save us from forgetting to add
> folders to the lakefile. But also we need APPS train by tomorrow so I want
> vericoder.py to run as fast as possible
>
> Maybe we should just replace lake build with lake env lean in all cases,
> so there's no slowdown?
>
> —
> Reply to this email directly, view it on GitHub
> <#245 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AB7QUTAP35C6DBHMBFQTBSD3TJYHJAVCNFSM6AAAAACG2R4H5KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTEMZYGMZDENRRGI>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***
> com>
>
|
Contributor
|
This was a good idea---I've incorporated a modified version of it into my experiments branch, and I'll raise a PR for that eventually |
Contributor
Author
|
may wanna use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies the Lean verification logic to automatically fall back to building individual files with 'lake env lean' when 'lake build' fails.