Skip to content

fix(raidname): Translate Drumbarka and Gregorius raid titles - #61

Merged
HU-Lee merged 1 commit into
mainfrom
fix/drumbarka-translation
Oct 1, 2026
Merged

HU-Lee merged 1 commit into
mainfrom
fix/drumbarka-translation

Conversation

@HU-Lee

@HU-Lee HU-Lee commented Oct 1, 2026

Copy link
Copy Markdown
Member

Summary

  • Allow spaces in boss names when parsing raid titles. The DB title for Drumbarka is 드럼통 게, which the old regex rejected, so the whole title fell back to Korean.
  • Replace the unused 드럼바르카 entry with 드럼통 게: Drumbarka / 油桶蟹.
  • Add 그레고리오: Gregorius / 格里高利.

Implementation notes

  • No official Chinese name for Drumbarka was found. Players use both 油桶蟹 and 铁桶蟹. 油桶蟹 matches most of the Bilibili videos already in our data.
  • Only S89-0, S90-0 and S93-0 change in raids.json. Every other title renders as before.

Evidence

  • Go: Static checks: PASS (scope: whole-repo)
  • The raidname test now uses the real DB title 총력전 S89 시가지 드럼통 게 for EN and ZH.
  • Dry run of process-raid --dry-run --recent 0 against production data: 0 of 56 entries keep Korean in name_en or name_zh. Compared with the live raids.json, only S89-0, S90-0 and S93-0 differ.

Boss names with a space failed the title regex, and the dictionary lacked the DB names, so S89, S90 and S93 kept Korean in name_en and name_zh.
@HU-Lee HU-Lee self-assigned this Oct 1, 2026
@HU-Lee
HU-Lee merged commit b142b77 into main Oct 1, 2026
4 checks passed
@HU-Lee
HU-Lee deleted the fix/drumbarka-translation branch October 1, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant