S2: preserve custom SMT options in resident sessions - #16
Merged
Merged
Conversation
kiranandcode
force-pushed
the
s2/resident-smt-options
branch
from
September 11, 2026 13:38
3d2d584 to
2effce8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resident verification currently rejects every custom SMT setting, even though the retained AIR context already owns the configured solver. Allow
--resident --smt-option random-seed=17and preserve the original ordered settings across rechecks, including provenance andspinoff-all.ready.smt_optionsreports the ordered startup name/value pairs so MCP callers can confirm their requested configuration. Settings are applied once through the existing verifier initialization path; rechecks reuse the original solver. Normal Verus resource-budget precedence is unchanged: the per-query budget overridesrlimit-per/reproducible-resource-limit.Reject the specific settings that break retained scopes:
incremental=false,global-declarations=true, andsingle_check_query=true. Names and values must fit single SMT atoms, preventing a setting from injecting commands. Other settings retain normal cvc5 validation and compatibility rules.Validation: all 15 resident subprocess tests pass. New tests cross custom settings with two buckets, parallel preparation, provenance, and spinoff contexts. SMT logs show ordered settings applied once per context; repeated valid/invalid checks launch no new solvers and close releases all children. Incompatible settings and embedded commands fail before solver startup. Actual MCP file/Cargo tests pass, including both provenance and spinoff-all with custom settings. Formatting and clippy with
-D warningspass.Targets
mainafter #14. Independent of the open error-reporting follow-up #15. MCP configuration is included in verus-tools-mcp PR #16.