Session gate: block when the MCP server reports toolchain_ok or solver_ok false - #22
Merged
Merged
Conversation
…r_ok false A reachable server whose Verus cannot run (missing binaries, or pinned solvers not matching what verus expects) now fails the fail-closed gate with the server's toolchain_error, instead of passing on identity alone. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ct36f7iXo3uSsex1CiSnL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The fail-closed SessionStart gate only checked that a
verus-tools-mcpserver answered with the right identity. A reachable server whose Verus could not run — binaries missing, or the pinned solvers not matching what verus expects — passed the gate and failed later, mid-proof.Change
mcp_probe._finalizenow reports unhealthy when theversionresult carriestoolchain_ok: falseorsolver_ok: false, surfacing the server'stoolchain_error. Only an explicitFalseblocks, so an older server that does not report a field is still judged on identity alone.Pairs with the verus-tools-mcp PR that adds
solver_ok(same branch name).🤖 Generated with Claude Code
https://claude.ai/code/session_016ct36f7iXo3uSsex1CiSnL