-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(backend): Optimize for 'Answers personal questions very well' (AI Clone v0.5) #8682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
choguun
wants to merge
125
commits into
BasedHardware:main
Choose a base branch
from
choguun:feat/ai-clone-prompt-rewrite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
125 commits
Select commit
Hold shift + click to select a range
7cd46f4
aidlc: AI clone — initial spec
choguun 623b3ea
aidlc: AI clone — revise spec to mirror existing codebase
choguun ed409e1
aidlc: AI clone — implementation plan
choguun c66484e
implement T-001: backend persona-chat endpoint + capability
choguun 7bd2d34
aidlc: T-001 done, plan updated
choguun da4c03b
implement T-002: shared persona_client module
choguun 662ead2
aidlc: T-002 done, plan updated
choguun 4e58818
implement T-003: omi-telegram-app skeleton + setup flow
choguun f91e176
aidlc: T-003 done, plan updated
choguun 50ac740
implement T-004: Telegram auto-reply dispatch + /toggle endpoint
choguun b601f24
aidlc: T-004 done, plan updated
choguun f94ea5c
fix: review findings for T-001..T-004
choguun 7d0f6ca
chore: stop tracking .aidlc/ (process artifact)
choguun f02f3e0
fix: use sys.modules.setdefault in test stubs to avoid polluting sibl…
choguun 56962f8
fix: address cubic review findings from PR #8437
choguun cf155d6
fix: address second cubic review (auth + error leakage)
choguun 4d9f44f
fix: /toggle returns same 403 for unknown chat_id and wrong token
choguun 59b24ac
fix: address maintainer review on PR #8437 (uid + auth + contract)
choguun 160c03c
fix: address cubic pass-2 (legacy key fallback + dedupe)
choguun a1f5c87
fix: address maintainer review (PR #8437) — token-leak + dead code
choguun 694ea95
chore(deps): add requirements-dev.txt for plugin and shared tests
choguun bd192e4
fix(deps): pin shared dev reqs to match consuming plugin runtime (cub…
choguun 0964207
feat(plugins): add WhatsApp AI-clone plugin (v0.2)
choguun 8a86eef
fix(whatsapp): address cubic review (9 issues — 3 P1, 6 P2)
choguun b903551
fix(whatsapp): validate display_phone_number before persisting pendin…
choguun 3c5bc62
test(whatsapp): unique test module names + fix state-leakage fixture
choguun db04645
feat(desktop): add AI Clone screen (T-006)
choguun dc119c4
fix(desktop): address cubic review on AI Clone (PR #8528)
choguun 9c2be94
fix(desktop): bind deep-link host check to the active plugin
choguun b2528c3
chore(desktop): add unreleased changelog fragment for AI Clone
choguun e3c57e4
chore(desktop): fix changelog fragment schema
choguun afe4ab8
fix(desktop): move AI Clone secrets from UserDefaults to Keychain
choguun cdeba25
fix(desktop): correct keychain isolation claim (cubic P2)
choguun 3890a19
test(desktop): use object(forKey:) not data(forKey:) for UserDefaults…
choguun f78d05c
feat(desktop): zero-config plugin auto-discovery + improved AI Clone UI
choguun a44d5b7
fix(desktop): correct AIClonePage footer copy (cubic P2)
choguun c525362
fix(desktop): mark PluginURLCard.checkHealth as @MainActor (cubic P1)
choguun c3d9534
fix(desktop): validate plugin_url + surface effectivePublicURL in Inf…
choguun 029a756
fix(desktop): extract applyDiscovery() from init + use local pluginUR…
choguun b925076
fix(desktop): disable auto-reply toggle in PluginCard (cubic P1)
choguun 35c83d2
fix(telegram): add .dockerignore matching WhatsApp's (maintainer review)
choguun 0b651b6
fix(whatsapp): hoist imports + sanitize HMAC mismatch log (maintainer…
choguun 6eaf4d1
test(desktop): pin applyDiscovery separation from init (cubic P2 foll…
choguun f346aa4
feat(desktop): add TelegramTokenValidator + tests (Tier 1 UX improvem…
choguun 5252289
feat(desktop): add QRCodeGenerator + tests (Tier 1 UX improvement)
choguun c4e6369
feat(desktop): add ClipboardWatcher + tests (Tier 1 UX improvement)
choguun f78b3be
feat(desktop): wire Tier 1 UX improvements into ConnectSheet
choguun ad82f34
chore(desktop): changelog entry for AI Clone Tier 1 UX improvements
choguun 0c1e8cf
fix(plugins): enforce bearer auth on /setup + /toggle (security blocker)
choguun 9f18893
fix(whatsapp): bump fastapi pin to 0.115.12 to drop vulnerable starlette
choguun 7bfcc5a
fix(telegram): bump fastapi pin to 0.115.12 to drop vulnerable starlette
choguun c101e03
test(telegram): add conftest defaulting OMI_DEV_MODE=1
choguun e5eb23d
test(whatsapp): add load_main_module helper to conftest
choguun 2a0e527
test(whatsapp): set placeholder WHATSAPP_APP_SECRET in auth tests
choguun 6f485fb
fix(whatsapp): use WABA id for subscribed_apps (P1 functional bug)
choguun e811396
fix(desktop): distinct handshake-completed vs timed-out states + QR s…
choguun aa6802b
fix(desktop): split ClipboardWatcher sources so string read is lazy (P1)
choguun a8f620f
test(desktop): update ClipboardWatcher tests for split sources
choguun 3e1b21c
fix(telegram): persist auto-generated webhook secret across restarts …
choguun 9eec388
test(telegram): cover webhook-secret persistence (6 cases)
choguun b452a43
fix(whatsapp): tighten storage file perms + propagate write errors (P1)
choguun ba07646
fix(whatsapp): use base HTTPError (not HTTPStatusError) for 2xx waba-…
choguun e01e921
fix(telegram): secure webhook-secret persistence (3 P1s from cubic)
choguun 5e8f424
test(telegram): update webhook-secret tests for hardened resolver
choguun e64a2d7
fix(whatsapp): unique temp filename per _save (P1 cubic)
choguun ac05dd5
feat(desktop): zero-config connect flow + plugin status + bug fixes
choguun f37a672
fix(desktop): security hardening — loopback URL check, remove backend…
choguun 466e1b4
docs(desktop): correct overpromising security comment on persona helpers
choguun 40c3a4e
fix(test): sync CI test fixes from PR #8531
choguun ac8afb2
fix(plugins): sync all security fixes from PR #8531 to desktop branch
choguun 07885c2
fix(plugins): sync concurrent-safe discovery files from #8531
choguun 3fb5b3d
test(whatsapp): isolate sys.modules via conftest helper to fix runtim…
choguun 32ff3d3
feat(plugins): expose Omi Chat Tools manifest for AI Clone plugins (T…
choguun 537f1e9
fix(telegram): restore send_message call lost in T-007 refactor
choguun 664cdc8
test(telegram): add Layer 1 E2E simulator + runbook
choguun 44a83b1
test(telegram): make sim_e2e actually catch the send_message regression
choguun b696b84
fix(backend): sanitize persona-chat logs + add is_a_persona + SSE format
choguun 878293e
fix(plugins): wamid dedup + phone normalization + telegram_client JSO…
choguun 3b85621
chore(plugins): add .dockerignore + telegram plugin; fix _shared README
choguun f0fdf52
fix(plugins): enforce bearer auth on /setup + /toggle (security blocker)
choguun 81df784
fix(persona_client, auth): cubic round-3 fixes
choguun 47821cf
chore(plugins): document .dockerignore build-context requirement
choguun d5a90d6
fix(whatsapp): hoist in-function imports + tighten dev-mode auth tests
choguun 5cc7089
fix(telegram): redesign chat-tools manifest — drop bot_token parameter
choguun 777b926
fix(whatsapp): redesign chat-tools manifest — drop access_token param…
choguun df7b7c9
docs(telegram): mark E2E_RUNBOOK.md as a process artifact
choguun 275d63d
fix(backend): persona chat streaming — use astream() instead of agene…
choguun 2d8a0b6
fix(plugins): harden plugin_discovery file/dir perms + require plugin…
choguun 0a57961
fix(backend): restore LangSmith tracer so persona chat run_ids are real
choguun cb43796
fix(backend): add PERSONA_CHAT permission text to oauth authorize
choguun 98b8987
fix(telegram): document COPY . . rationale alongside .dockerignore
choguun f0fcb6b
fix(telegram): document /toggle auth + body schema in README
choguun 53b8ff4
fix(whatsapp): normalize tz-aware/naive timestamps in should_nudge
choguun 12b6976
fix(test): assert auto-reply-disabled nudge body mentions 'auto-reply'
choguun 8362e42
fix(sim_e2e): use exported STORAGE_DIR + plugin.log redirect + token …
choguun 0eefbc3
style: apply black --line-length 120 to fixed files
choguun ff47f07
fix(backend): pass langsmith run_id via RunnableConfig (not just trac…
choguun 1331e92
fix(telegram): correct README /toggle docs + remove unused pytest import
choguun 004546f
fix: address 3 cubic follow-up findings on PR #8531
choguun 4683c4e
chore(telegram): remove stale sim_e2e.py Layer-1 E2E script
choguun a21627c
chore(telegram): remove stale E2E_RUNBOOK.md + clean Dockerfile comment
choguun 817410a
fix(whatsapp): refresh stale /toggle docs after bearer-token redesign
choguun 030d958
fix(telegram): refresh manifest comments + add bearer conftest
choguun f20a7c8
fix: auth whitespace token rejection + qos test update for persona_chat
choguun b7031ea
fix(plugins): concurrent-safe discovery files + unique tmp filenames
choguun 021b441
fix(backend): rewrite persona prompt to stop 'AI clone' leaks (T-019)
choguun 440f89f
feat(plugins): pass sender + recent messages to persona-chat (T-020)
choguun 0ebb57d
feat(backend): memory RAG for persona prompt (T-022)
choguun 6b0a16f
test(backend): fix TestReEnableRouterBehavior __spec__ errors after T…
choguun 64d8725
fix(plugins,backend): address cubic AI review on PR #8682
choguun 11c1aad
fix(desktop,plugins): address remaining cubic AI review on PR #8682
choguun bb3c8bf
fix(plugins,backend): round 3 cubic AI review on PR #8682
choguun fd98424
fix(plugins): scope no-fsync optimization to history writes only
choguun 92677d3
fix(plugins): restore durable _save + add parent-dir fsync
choguun ff283d5
fix(desktop): send tunnel/public URL as webhook target in Connect flow
choguun e0e5462
fix(desktop): always refresh publicBaseURL from discovery on startup
choguun 8380259
docs(desktop): add E2E stack runner + AI Clone testing guide
choguun 725924b
fix(ai-clone): address PR #8682 reviews — prompt-injection + mixed-co…
choguun 2389bbb
fix(ai-clone): address cubic review #4601469127 — 3 real findings
choguun b9d5491
fix(ai-clone): address cubic review #4601668066 — 3 real findings
choguun 0ce0c6d
fix(ai-clone): address cubic review #4601825081 — spy patching wrong …
choguun 66117c9
docs(desktop): strip agent-skill frontmatter from ai-clone.md (review…
choguun f9bc844
style(backend): run black on apps.py post-rebase
choguun c21c8a2
fix(backend): unstub google.* + utils.llm so rebase works with main's…
choguun bab955f
fix(test): remove fragile _NullCallback fallback (cubic review #46076…
choguun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.