ci: bump Flutter 3.35.3 → 3.41.9#8581
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
mdmohsin7
added a commit
that referenced
this pull request
Jun 29, 2026
…#8583) ## What Fixes pre-existing test failures that had drifted from the app code. These were surfaced while verifying the Flutter 3.41.9 upgrade (#8581) but are **independent of it** — they fail on `main` today. ### Env fakes out of sync with `EnvFields` (3 files) `lib/env/env.dart` swapped Mixpanel → PostHog: dropped `mixpanelProjectToken` + `growthbookApiKey`, added `posthogApiKey`. The test fakes in `env_test.dart`, `env_staging_test.dart`, `env_empty_staging_test.dart` were stale, causing: - **error** `Missing concrete implementation of 'getter EnvFields.posthogApiKey'` - 2× **warning** `override_on_non_overriding_member` (the removed getters) Fix: rename `mixpanelProjectToken`→`posthogApiKey`, drop `growthbookApiKey` → fakes now match the interface exactly. ### `DeviceType.frame` removed (`capture_provider_test.dart`) `frame` was removed from the `DeviceType` enum (commit `ecb30e1cb`). Three tests still referenced it → **error** `There's no constant named 'frame' in 'DeviceType'`, which meant the **entire file failed to compile and never ran**. Fixes: - Dropped the 2 redundant "no native route" cases for Frame (that path is already covered by `bee`/`fieldy`/`limitless`/`plaud`). - Switched the unique "switching from no-route device to Omi gains route" case to `fieldy`. Once the file compiled, it exposed two further latent bugs in tests that had never executed: - **`Env` never initialized** → `LateInitializationError` on `omi`-route paths reading `Env.apiBaseUrl`. Added an `Env.init(stub)` in `setUpAll`. - **Wrong assertion** — `SharedPreferencesUtil.getString` returns a non-nullable `String` defaulting to `''`, so a cleared `nativeBleStreamConfig` is `''`, not `null`. Changed `isNull` → `isEmpty` (2 spots). ## Verification (Flutter 3.41.9 / Dart 3.11.5) - `flutter analyze` on the 4 files: **0 errors** (was 6). - `flutter test` on the 4 files: **72 tests pass** (was: 6 compile errors + 10 runtime failures). ## Out of scope The full suite still has **4 unrelated pre-existing logic failures** in files this PR doesn't touch — `audio_wave_painter_test` (`shouldRepaint` 0.01 epsilon boundary) and `ring_protocol_test` (off-by-one buffer boundary). Both are SDK-version-independent pure-Dart logic and need their own investigation; left for a separate fix. <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/BasedHardware/omi/pull/8583?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->
![https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source](https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source){kind=link}
![https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img](https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img){kind=link}
![https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a](https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the repo's Flutter toolchain from 3.35.3 (10 months old) to 3.41.9 (latest patch in the 3.41 line, bundles Dart 3.11.5, released 2026-04-30).
flutter:pins3.35.3→3.41.9(this is what actually drives app builds)Flutter SDK (v…)strings updated (macOS + Windows setup scripts)flutter doctorexample output + "Recommended versions" bumped to 3.41.93.24.1, ~13 months old), unreferenced in any docs/CI/scripts, and FVM isn't part of the workflow. Dead config.matcher0.12.18→0.12.19 andtest_api0.7.9→0.7.10, the versions the 3.41.9 SDK pins.github/workflows/lint.ymlis intentionally left onchannel: stable(unpinned) — unchanged.Verification (run locally on Flutter 3.41.9 / Dart 3.11.5)
flutter pub getflutter gen-l10nflutter analyzelib/(shipping code)flutter build apk --debug --flavor deviOS not built locally (CocoaPods/Xcode) — will be validated by Codemagic.
Pre-existing test errors (NOT from this upgrade)
flutter analyzereports errors intest/that are pre-existing test/code drift independent of the SDK version (DeviceType.frameremoved;EnvFields.posthogApiKeynot implemented in fakes). Fixed separately in #8583.