test(desktop): add tool stall state preview harness#8471
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a DEBUG-only SwiftUI preview harness to visually exercise desktop chat tool-call row states (running/slow/stalled/failed/completed) without requiring a live agent bridge, plus an unreleased desktop changelog fragment.
Changes:
- Added a
#Preview("Tool call stall states")block inChatPage.swiftthat renders representativeToolCallsGroupconfigurations. - Added an unreleased desktop changelog fragment describing the preview harness.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| desktop/macos/Desktop/Sources/MainWindow/Pages/ChatPage.swift | Adds a DEBUG-only SwiftUI preview to render tool-call UI states in a stable, offline harness. |
| desktop/macos/changelog/unreleased/tool-stall-preview-harness.json | Adds an unreleased changelog entry describing the change (currently framed as developer-only). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Nice foundation for the stall-state preview harness. The Since this is intentionally draft, no action needed from review yet — mark it ready when the runtime/fake-bridge follow-up lands or you're happy with this as a standalone step. |
|
Nice preview harness — this is a clean, well-scoped One small note: using Makes sense as a draft while the fake-bridge / dev-runtime follow-up (#7555 thread) comes together. Nothing blocking on the harness itself — happy to review the stronger follow-up when it lands. Thanks @eulicesl! |
|
Follow-up check: the Copilot changelog thread is addressed. The DEBUG-only preview harness changelog fragment was removed, |
Summary
.running,.slow,.stalled,.failed, and.completedtool rows without requiring a live bridge.Why draft
This is the first visual harness step from PR #7555 follow-up work. It is intentionally draft because the stronger follow-up is still a fake-bridge/dev runtime path that can drive the full chat surface end-to-end.
Verification
xcrun swift build -c debug --package-path desktop/macos/Desktop-> build completepython3 .github/scripts/check-desktop-changelog.py --base upstream/main --head HEAD-> Desktop changelog fragment foundgit diff --check-> cleanNot included yet