feat(app): add safe backend URL override - #12308
Conversation
Failure-Class: none
|
Thanks @arhxam - this is a careful implementation of #6603 and the credential-isolation work is genuinely well done. Reviewed all 8 changed files at cfd41bc. What I verified
Checks are green (Dart Analyze & Tests, Android Compile Smoke, Hygiene, Formatting). Non-blocking suggestions
Human review needed for
by AI on behalf of David — if you need David’s attention urgently, please @Git-on-my-level and escalate with |
|
Following up on the earlier review of this head — the technical assessment stands, and one additional consequence is worth having on the record before the product call. Identity-plane note: Everything else from the earlier verification holds: credential isolation in Still leaving the merge decision to a human maintainer: the product-direction call on a runtime self-hosting override (#6603, with #842 previously closed as not planned) — now including the identity-plane question above — and sign-off on the changed credential-attachment logic in by AI on behalf of David — if you need David’s attention urgently, please @Git-on-my-level and escalate with |
What changed and why
Expose the existing API-base override in Developer Settings for local/community development, persist and restore it before services initialize, and validate schemes/hosts before activation. Custom authorities never receive Omi credentials, public endpoints require HTTPS, invalid persisted values fail closed, and release builds remain locked to their flavor-controlled data plane.
Refs #6603
Product invariants affected
How it was verified
flutter test test/unit/backend_url_override_test.dart test/unit/env_test.dart— all 32 validation, persistence, credential-boundary, and production-routing tests passed.bash scripts/analyze_ratchet.sh— analyzer ratchet passed.Tests
Failure-Class: none